Merge pull request #243 from koianaoki/feature/fix-issue-229-delete-update-statement

Author: Maxteabag

sqlit/domains/results/ui/mixins/results.py

@@ -1032,7 +1032,9 @@ def action_delete_row(self: ResultsMixinHost) -> None:
 
         try:
             cursor_row, _cursor_col = table.cursor_coordinate
-            row_values = table.get_row_at(cursor_row)
+            row_values = [
+                _strip_table_markup(table, v) for v in table.get_row_at(cursor_row)
+            ]
         except Exception:
             return
 
@@ -1114,7 +1116,9 @@ def action_edit_cell(self: ResultsMixinHost) -> None:
 
         try:
             cursor_row, cursor_col = table.cursor_coordinate
-            row_values = table.get_row_at(cursor_row)
+            row_values = [
+                _strip_table_markup(table, v) for v in table.get_row_at(cursor_row)
+            ]
         except Exception:
             return
 

tests/unit/test_results_copy_markup.py

@@ -85,3 +85,47 @@ def test_copy_cell_preserves_literal_brackets_when_not_rendering_markup() -> Non
     app = _FakeApp([("[bold]hello",)], render_markup=False)
     app.action_copy_cell()
     assert app.clipboard_text == "[bold]hello"
+
+class _FakeQueryInput:
+    def __init__(self) -> None:
+        self.text = ""
+        self.cursor_location = (0, 0)
+        self.read_only = True
+
+    def focus(self) -> None:
+        pass
+
+
+class _FakeEditApp(_FakeApp):
+    def __init__(self, cells: list[tuple[str, ...]], columns: list[str]) -> None:
+        super().__init__(cells, render_markup=True)
+        self._columns = columns
+        self.query_input = _FakeQueryInput()
+        self._suppress_autocomplete_once = False
+
+    def _get_active_results_context(self) -> tuple[Any, list, list, bool]:
+        return self._table, self._columns, [], False
+
+    def _get_active_results_table_info(self, _table: Any, _stacked: bool) -> dict[str, Any]:
+        return {"name": "users", "columns": []}
+
+    def action_focus_query(self) -> None:
+        pass
+
+    def _update_footer_bindings(self) -> None:
+        pass
+
+    def _update_vim_mode_visuals(self) -> None:
+        pass
+
+
+def test_delete_row_strips_filter_markup_before_generating_sql() -> None:
+    app = _FakeEditApp([("[bold #FFFF00]Ja[/]ne",)], ["name"])
+    app.action_delete_row()
+    assert app.query_input.text == "DELETE FROM users WHERE name = 'Jane';"
+
+
+def test_edit_cell_strips_filter_markup_before_generating_sql() -> None:
+    app = _FakeEditApp([("[bold #FFFF00]Ja[/]ne",)], ["name"])
+    app.action_edit_cell()
+    assert "WHERE name = 'Jane';" in app.query_input.text