Use a more appropriate exception for MFA login failure

Amodio · web-flow · commit a7e306d343d0 · 2026-02-03T06:48:19.000+01:00
diff --git a/firstrade/account.py b/firstrade/account.py
@@ -8,6 +8,7 @@
 from firstrade import urls
 from firstrade.exceptions import (
     AccountResponseError,
+    LoginError,
     LoginRequestError,
     LoginResponseError,
 )
@@ -262,7 +263,7 @@ def _handle_mfa(self):
             }
             response = self.session.post(urls.verify_pin(), data=data)
         else:
-            raise LoginResponseError(
+            raise LoginError(
                 "MFA required but no valid MFA method "
                 "was provided (pin, email/phone, or mfa_secret)."
             )

Original file line number	Diff line number	Diff line change
`@@ -8,6 +8,7 @@`
`8`	`8`	`from firstrade import urls`
`9`	`9`	`from firstrade.exceptions import (`
`10`	`10`	`AccountResponseError,`
	`11`	`+ LoginError,`
`11`	`12`	`LoginRequestError,`
`12`	`13`	`LoginResponseError,`
`13`	`14`	`)`
`@@ -262,7 +263,7 @@ def _handle_mfa(self):`
`262`	`263`	`}`
`263`	`264`	`response = self.session.post(urls.verify_pin(), data=data)`
`264`	`265`	`else:`
`265`		`- raise LoginResponseError(`
	`266`	`+ raise LoginError(`
`266`	`267`	`"MFA required but no valid MFA method "`
`267`	`268`	`"was provided (pin, email/phone, or mfa_secret)."`
`268`	`269`	`)`