Merge pull request #73 from Amodio/Amodio-mfa-error

Handle missing MFA method in login process

Author: MaxxRK

firstrade/account.py

@@ -8,6 +8,7 @@
 from firstrade import urls
 from firstrade.exceptions import (
     AccountResponseError,
+    LoginError,
     LoginRequestError,
     LoginResponseError,
 )
@@ -261,6 +262,11 @@ def _handle_mfa(self):
                 "t_token": self.t_token,
             }
             response = self.session.post(urls.verify_pin(), data=data)
+        else:
+            raise LoginError(
+                "MFA required but no valid MFA method "
+                "was provided (pin, email/phone, or mfa_secret)."
+            )
         self.login_json = response.json()
         if self.login_json["error"] == "":
             if self.pin or self.mfa_secret is not None: