Add code optimisation in asn1write

Ben Taylor · Ben Taylor · commit 4a74be39cb16 · 2026-03-17T08:15:59.000Z
Signed-off-by: Ben Taylor &lt;ben.taylor@linaro.org&gt;
diff --git a/utilities/asn1write.c b/utilities/asn1write.c
@@ -403,7 +403,6 @@ int mbedtls_asn1_write_integer(unsigned char **p,
                                size_t integer_length)
 {
 
-    int asn1_frame_size = 0;
     unsigned int number_of_leading_zeros = 0;
     size_t output_buffer_size = (*p-start);
     const unsigned char *integer_start = NULL;
@@ -454,12 +453,6 @@ int mbedtls_asn1_write_integer(unsigned char **p,
         }
     }
 
-    asn1_frame_size =
-        mbedtls_asn1_write_len_and_tag(p, start, integer_length, MBEDTLS_ASN1_INTEGER);
-    if (asn1_frame_size < 0) {
-        return asn1_frame_size;//TC4 mbedtls_asn1_write_len_and_tag failed.
-    }
-
-    return asn1_frame_size;
+    return mbedtls_asn1_write_len_and_tag(p, start, integer_length, MBEDTLS_ASN1_INTEGER);
 }
 #endif /* MBEDTLS_ASN1_WRITE_C */

Original file line number	Diff line number	Diff line change
`@@ -403,7 +403,6 @@ int mbedtls_asn1_write_integer(unsigned char **p,`
`403`	`403`	`size_t integer_length)`
`404`	`404`	`{`
`405`	`405`
`406`		`- int asn1_frame_size = 0;`
`407`	`406`	`unsigned int number_of_leading_zeros = 0;`
`408`	`407`	`size_t output_buffer_size = (*p-start);`
`409`	`408`	`const unsigned char *integer_start = NULL;`
`@@ -454,12 +453,6 @@ int mbedtls_asn1_write_integer(unsigned char **p,`
`454`	`453`	`}`
`455`	`454`	`}`
`456`	`455`
`457`		`- asn1_frame_size =`
`458`		`- mbedtls_asn1_write_len_and_tag(p, start, integer_length, MBEDTLS_ASN1_INTEGER);`
`459`		`- if (asn1_frame_size < 0) {`
`460`		`- return asn1_frame_size;//TC4 mbedtls_asn1_write_len_and_tag failed.`
`461`		`- }`
`462`		`-`
`463`		`- return asn1_frame_size;`
	`456`	`+ return mbedtls_asn1_write_len_and_tag(p, start, integer_length, MBEDTLS_ASN1_INTEGER);`
`464`	`457`	`}`
`465`	`458`	`#endif /* MBEDTLS_ASN1_WRITE_C */`