Skip to content

Commit 62cfb00

Browse files
author
Ben Taylor
committed
remove data_t
1 parent e7f58a3 commit 62cfb00

1 file changed

Lines changed: 6 additions & 13 deletions

File tree

tests/suites/test_suite_bignum_core.function

Lines changed: 6 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -1484,35 +1484,28 @@ exit:
14841484
/* END_CASE */
14851485

14861486
/* BEGIN_CASE */
1487-
//input bignum integer
1488-
//long integer test integer that is too large
1489-
//buffer_test, test buffer that is too smalll or large.
1490-
//expected result expected output of the function.
1491-
//declare the frame internally
14921487
void encode_decode_asn1_bignum(const data_t *input, int asn1_frame_length, int expected_result)
14931488
{
14941489
int n = 1;
14951490
int output_buffer_length;
14961491
unsigned char* p = NULL;
14971492
unsigned char *endian_swap=NULL;
1493+
unsigned char *asn1_frame=NULL;
14981494
size_t integer_length;
1499-
data_t asn1_frame;//TODO remove this.
15001495

1501-
asn1_frame.x=NULL;
1502-
asn1_frame.len=asn1_frame_length;
1503-
TEST_CALLOC(asn1_frame.x, asn1_frame.len);
1496+
TEST_CALLOC(asn1_frame, asn1_frame_length);
15041497
TEST_CALLOC(endian_swap, input->len);
15051498

15061499
unsigned char *integer_head = NULL;
15071500

1508-
p = asn1_frame.x + asn1_frame.len;
1501+
p = asn1_frame + asn1_frame_length;
15091502

1510-
output_buffer_length = mbedtls_asn1_write_integer(&p, asn1_frame.x, input->x, input->len);
1503+
output_buffer_length = mbedtls_asn1_write_integer(&p, asn1_frame, input->x, input->len);
15111504

15121505
TEST_EQUAL(output_buffer_length,expected_result);
15131506

15141507
if(output_buffer_length>0){
1515-
TEST_EQUAL(mbedtls_asn1_get_integer(&p, asn1_frame.x + asn1_frame.len, &integer_head, &integer_length), 0);//TODO capture return
1508+
TEST_EQUAL(mbedtls_asn1_get_integer(&p, asn1_frame + asn1_frame_length, &integer_head, &integer_length), 0);//TODO capture return
15161509
if(*(char *)&n == 1) { //detect processor endian and convert to it if required.
15171510
mbedtls_mpi_core_write_be((const mbedtls_mpi_uint*)integer_head, integer_length/8, endian_swap, integer_length);
15181511
}else{
@@ -1522,7 +1515,7 @@ void encode_decode_asn1_bignum(const data_t *input, int asn1_frame_length, int e
15221515
}
15231516

15241517
exit:
1525-
mbedtls_free(asn1_frame.x);
1518+
mbedtls_free(asn1_frame);
15261519
mbedtls_free(endian_swap);
15271520
}
15281521
/* END_CASE */

0 commit comments

Comments
 (0)