Backport 1.1: IAR build fixes after 1.1.0 by gilles-peskine-arm · Pull Request #708 · Mbed-TLS/TF-PSA-Crypto

gilles-peskine-arm · 2026-03-11T22:42:37Z

Fix the build of the library and the unit tests with IAR.

This is the 1.1 version. I'll do the development version once the 1.1 version is approved or close to being appoved, since development is a moving target and there's already one more warning (in the new MLDSA code) now.

The build was already broken in 1.0.0, but #694 made it worse by adding deprecation warnings on the use of many standard library functions.

Needs preceding PR: submodule update, although this is only needed to actually fix the IAR build, not to pass our CI.

Needs preceding PR:

PR checklist

changelog provided
mbedtls development PR provided IAR build fixes after 4.1.0 mbedtls#10635
mbedtls 4.1 PR TODO
TF-PSA-Crypto development PR TODO
TF-PSA-Crypto 1.1 PR provided Backport 1.1: IAR build fixes after 1.1.0 #708
framework PR provided IAR build fixes before 1.1.0/4.1.0/3.6.6: framework support mbedtls-framework#289; Teach check_names about platform requirement macros in common.h mbedtls-framework#299
3.6 PR provided Backport 3.6: IAR build fixes after 3.6.6 mbedtls#10636
tests built (but did not link) the library, the unit test support code and the unit tests (but not the programs) in the baremetal config with IAR 9.40 for Arm

Copilot

Pull request overview

Fixes IAR build issues/regressions in the library and unit tests (notably IAR-specific deprecation warnings and diagnostics).

Changes:

Adds IAR-specific configuration and diagnostic suppressions to unblock compilation of library and test code.
Updates unit tests to avoid constructs that trigger IAR warnings/errors (e.g., TEST_ASSERT(!"msg") → TEST_FAIL("msg")).
Adjusts platform/header behavior around C11 Annex K and zeroization functions; updates framework submodule.

Reviewed changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/suites/test_suite_rsa.function	Simplifies a test callsite argument (always `NULL`).
tests/suites/test_suite_psa_crypto_pake.function	Replaces assertion idiom with explicit test failure to satisfy IAR.
tests/suites/test_suite_psa_crypto.function	Same as above for PSA crypto suite variant.
tests/suites/test_suite_alignment.function	Removes unused local buffer initialization from alignment test.
tests/suites/main_test.function	Adds IAR DLIB config and suppresses specific IAR diagnostics in test runner TU.
tests/suites/host_test.function	Changes integer parsing validation for IAR compatibility.
platform/platform_util.c	Enables `memset_s` path even under IAR.
framework	Updates framework submodule pointer.
drivers/builtin/src/psa_crypto_cipher.c	Suppresses IAR goto/initialization diagnostic in cipher module TU.
drivers/builtin/src/bignum.c	Suppresses IAR goto/initialization diagnostic in bignum module TU.
drivers/builtin/src/aes.c	Fixes logic for selecting AES implementation return value under hardware-only builds.
core/tf_psa_crypto_platform_requirements.h	Documents IAR Annex K side-effect on deprecations.
core/tf_psa_crypto_common.h	Adds IAR-specific workaround redefining `__DEPREC` after enabling Annex K.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

Copilot · 2026-03-12T10:00:26Z

    long value = strtol(str, &end, 0);
-    if (errno == EINVAL || *end != '\0') {
+    if (*end != '\0' || end == str) {
        mbedtls_fprintf(stderr,
                        "Expected integer for parameter and got: %s\n", str);
        return KEY_VALUE_MAPPING_NOT_FOUND;


strtol() errors aren’t fully handled here: overflow/underflow sets errno = ERANGE and returns a clamped value, which would currently be accepted and can yield incorrect test parameter values. Consider setting errno = 0 before calling strtol() and rejecting inputs when errno == ERANGE (in addition to the existing end == str / trailing characters checks).

Copilot · 2026-03-12T10:00:26Z

+#if defined(__IAR_SYSTEMS_ICC__)
+/* Suppress a very overeager warning from IAR: it dislikes a forward goto
+ * that bypasses the initialization of a variable, even if that variable
+ * is not used after the jump. (This is perfectly valid C; it would only
+ * be invalid C if jumping into a block from outside that block.)
+ */
+#pragma diag_suppress=Pe546 // transfer of control bypasses initialization
+
+/* Temporarily suppress a perfectly reasonable warning from IAR that
+ * comes up very often in our unit tests: silent conversion of int to
+ * an enum type.
+ *
+ * Remove this when https://github.com/Mbed-TLS/TF-PSA-Crypto/issues/707
+ * is fixed.
+ */
+#pragma diag_suppress=Pe188 // enumerated type mixed with another type
+#endif


These diagnostic suppressions apply to the remainder of the translation unit and are not restored, which can mask unrelated warnings and make future debugging harder. Consider scoping them (e.g., using IAR’s diagnostic push/pop if available, or restoring with #pragma diag_default=Pe546 / #pragma diag_default=Pe188 after the affected section) so only the intended code patterns are covered.

Copilot · 2026-03-12T10:00:26Z

+#include <stddef.h>
+#undef __DEPREC
+#define __DEPREC
+#endif


Redefining a toolchain/system macro like __DEPREC in a widely-included header can leak into downstream includes and alter how unrelated headers declare deprecations (effectively disabling deprecation annotations beyond this library). A more contained approach would be to localize this workaround to implementation files, or to bracket only the specific system header inclusions that trigger the unwanted deprecations (and then restore the original macro), or to prefer a compiler pragma/warning-control mechanism where possible.

Copilot · 2026-03-12T10:00:26Z

+#if defined(__IAR_SYSTEMS_ICC__)
+/* In IAR (at least IAR 9.40 for Arm), enabling the C11 annex K functions
+ * (memset_s(), memcpy_s(), ...) with `#define __STDC_WANT_LIB_EXT1__ 1`
+ * causes the non-s functions to be declared as deprecatd. We want some


Corrected spelling of 'deprecatd' to 'deprecated'.

Suggested change

* causes the non-s functions to be declared as deprecatd. We want some

* causes the non-s functions to be declared as deprecated. We want some

GCC is ok with it but IAR frowns. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

We enable `__STDC_WANT_LIB_EXT1__` because we want some C11 Annex K functions (`memset_s()` and `gmtime_s()`). This causes IAR 9.40 (and likely other versions) to deprecate every function that has an annex K equivalent, which we don't want. Hack around the deprecation warning. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

We had previously disabled the use of `memset_s` on IAR in Mbed-TLS/mbedtls#7950 because it wasn't found when building. But I believe the problem was not that IAR doesn't provide `memset_s`: as far as I can tell, IAR added C11 support in version 8, including Annex K. Rather, the problem was that at the time, we defined `__STDC_WANT_LIB_EXT1__` too late, after some system headers were already included, which made it ineffective. This ordering problem is fixed now, so do use `memset_s` when it's supposed to be available. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

IAR emits Pe546 a "transfer of control bypasses initialization" diagnostic in many cases that are perfectly valid and idiomatic C. Disable that warning in places where IAR complains. This includes a lot of test suites. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Standard C doesn't have `EINVAL`. Check for invalid inputs in a portable way. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Temporarily suppress a perfectly reasonable warning from IAR that comes up very often in our unit tests: silent conversion of int to an enum type. Improvement tracked as Mbed-TLS#707 Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

If `NULL` is an integer constant expression with the value 0 (which C allows), the expression `prng ? NULL : NULL` is not an integer constant expression so it is not a null pointer constant, and thus it is not a pointer. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

This gets rid of a warning from IAR. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Even without CI validation, we can promise that we've made the situation better, and an IAR warning has been reported in Mbed-TLS/mbedtls#10648 Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

gilles-peskine-arm added this to Roadmap pull requests (new board) Mar 11, 2026

gilles-peskine-arm added size-s Estimated task size: small (~2d) priority-high High priority - will be reviewed soon needs-preceding-pr Requires another PR to be merged first needs-ci Needs to pass CI tests labels Mar 11, 2026

github-project-automation Bot moved this to In Development in Roadmap pull requests (new board) Mar 11, 2026

This was referenced Mar 11, 2026

IAR build fixes after 4.1.0 Mbed-TLS/mbedtls#10635

Open

Backport 3.6: IAR build fixes after 3.6.6 Mbed-TLS/mbedtls#10636

Open

IAR build fixes before 1.1.0/4.1.0/3.6.6: framework support Mbed-TLS/mbedtls-framework#289

Merged

gilles-peskine-arm requested a review from Copilot March 12, 2026 09:56

Copilot AI reviewed Mar 12, 2026

View reviewed changes

mpg added needs-work and removed needs-preceding-pr Requires another PR to be merged first labels Mar 17, 2026

gilles-peskine-arm changed the title ~~IAR build fixes before 1.1.0~~ IAR build fixes after 1.1.0 Mar 19, 2026

gilles-peskine-arm force-pushed the iar-1.1.0 branch from 924231e to d8d303b Compare March 20, 2026 20:23

gilles-peskine-arm added needs-preceding-pr Requires another PR to be merged first and removed needs-work labels Apr 10, 2026

gilles-peskine-arm mentioned this pull request Apr 10, 2026

Teach check_names about platform requirement macros in common.h Mbed-TLS/mbedtls-framework#299

Open

6 tasks

gilles-peskine-arm force-pushed the iar-1.1.0 branch from d8d303b to 2764aa5 Compare April 10, 2026 17:23

gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review labels Apr 10, 2026

gilles-peskine-arm added 9 commits April 15, 2026 12:29

Fix dead code warning in aes.c

3c48006

GCC is ok with it but IAR frowns. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Improve non-portable EINVAL check for strtol

8168295

Standard C doesn't have `EINVAL`. Check for invalid inputs in a portable way. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

IAR: allow test code to use stdio

37a6dc8

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Remove unused variable

692abdb

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

gilles-peskine-arm added 3 commits April 15, 2026 12:29

Use TEST_FAIL rather than a TEST_ASSERT(!"...") hack

7b86815

This gets rid of a warning from IAR. Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Add changelog entry

678056f

Even without CI validation, we can promise that we've made the situation better, and an IAR warning has been reported in Mbed-TLS/mbedtls#10648 Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

Update framework with check_names fix for IAR platform requirements

4ecafcf

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>

gilles-peskine-arm force-pushed the iar-1.1.0 branch from 2764aa5 to 4ecafcf Compare April 15, 2026 10:33

gilles-peskine-arm changed the base branch from development to tf-psa-crypto-1.1 April 15, 2026 10:33

gilles-peskine-arm changed the title ~~IAR build fixes after 1.1.0~~ Backport 1.1: IAR build fixes after 1.1.0 Apr 15, 2026

gilles-peskine-arm mentioned this pull request Apr 28, 2026

Fix and test mldsa-native integration on IAR #656

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport 1.1: IAR build fixes after 1.1.0#708

Backport 1.1: IAR build fixes after 1.1.0#708
gilles-peskine-arm wants to merge 12 commits intoMbed-TLS:tf-psa-crypto-1.1from
gilles-peskine-arm:iar-1.1.0

gilles-peskine-arm commented Mar 11, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Copilot AI Mar 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	* causes the non-s functions to be declared as deprecatd. We want some
	* causes the non-s functions to be declared as deprecated. We want some

Conversation

gilles-peskine-arm commented Mar 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 12, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gilles-peskine-arm commented Mar 11, 2026 •

edited

Loading