Remove pattern constraint from location field#720
Open
parmi93 wants to merge 1 commit intoMbed-TLS:developmentfrom
Open
Remove pattern constraint from location field#720parmi93 wants to merge 1 commit intoMbed-TLS:developmentfrom
parmi93 wants to merge 1 commit intoMbed-TLS:developmentfrom
Conversation
According to the "PSA Certified Crypto Driver Interface" (Section 3.2) https://arm-software.github.io/psa-api/crypto-driver/1.0/body/manifest.html#driver-description-top-level-element, the location field may be either a non-negative integer or a C constant expression of type psa_key_location_t. For this reason, the pattern constraint is being removed, allowing the user to input any value. Signed-off-by: Parminder Singh <61920513+parmi93@users.noreply.github.com>
Author
|
Now user can set up a JSON manifest file like this: {
"prefix": "stsafe_a110",
"type": "opaque",
"location": "STSAFE_A110_LOCATION", /* <- Previously, only hexadecimal values were permitted. */
"headers": [
"stsafe_a110_psa_driver.h"
],
"capabilities": [
{
"entry_points": [
"_comment": "bla bla"
],
}
]
}
#define STSAFE_A110_LOCATION ((psa_key_location_t)0x800001) |
Contributor
|
I'm curious, are you finding the script to be usable as it is? I'm aware that only a small subset of the functionality is implemented. |
Author
|
The script ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to the "PSA Certified Crypto Driver Interface" (Section 3.2) https://arm-software.github.io/psa-api/crypto-driver/1.0/body/manifest.html#driver-description-top-level-element, the location field may be either a non-negative integer or a C constant expression of type
psa_key_location_t. For this reason, the pattern constraint is being removed, allowing the user to input any value.