psa_crypto.c: Fix ifdefs to avoid build warning#723
Conversation
Add a couple of missing ifdefs to avoid having unreachable code with AT_LEAST_ONE_BUILTIN_KDF not defined, which otherwise causes a build warning with clang. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
|
Adding some relevant details for the 2nd reviewer. This is the PR in the Zephyr fork of TF-PSA-Crypto repo: This is the main Zephyr PR with a command on how to reproduce the issue: This is the log of the failure: |
Really? I'm seeing the same function with the same structure in 3.6. Why wouldn't we want to backport those changes? |
|
I'm applying "needs-backport" not as a way to insist this needs backports, but if it doesn't need backports, I think it needs a better justification why. |
|
@mpg I've added backport PRs:
Minor note: I think we should add the |
|
@mpg I've also added you as reviewer for this PR because I'm doing the backports and I cannot self-approve PRs |
Description
Add a couple of missing ifdefs to avoid having unreachable code with AT_LEAST_ONE_BUILTIN_KDF not defined, which otherwise causes a build warning with clang.
PR checklist