Fix PSA lifetime persistence argument#731
Open
parmi93 wants to merge 2 commits intoMbed-TLS:developmentfrom
Open
Fix PSA lifetime persistence argument#731parmi93 wants to merge 2 commits intoMbed-TLS:developmentfrom
parmi93 wants to merge 2 commits intoMbed-TLS:developmentfrom
Conversation
Pass `PSA_KEY_PERSISTENCE_DEFAULT` to `PSA_KEY_LIFETIME_FROM_PERSISTENCE_AND_LOCATION()` instead of `PSA_KEY_LIFETIME_PERSISTENT`. The macro expects a `psa_key_persistence_t`, but the previous code incorrectly passed a value already representing a constructed lifetime. This aligns the call with the API specification and ensures correct lifetime construction. Signed-off-by: Parminder Singh <parminder.sh93@gmail.com>
Contributor
|
Hi @parmi93, many thanks for submitting this. It looks like the branch on you fork is based of a fairly old commit form tf-psa-crypto. Are you able to update the fork and rebase, as I think the current CI issue is unrelated to your changes and should disappear if you pull in the relevant changes. |
Author
|
Hi @bjwtaylor I merged the upstream |
bjwtaylor
added
needs-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pass
PSA_KEY_PERSISTENCE_DEFAULTtoPSA_KEY_LIFETIME_FROM_PERSISTENCE_AND_LOCATION()instead ofPSA_KEY_LIFETIME_PERSISTENT. The macro expects apsa_key_persistence_t, but the previous code incorrectly passed a value already representing a constructed lifetime. This aligns the call with the API specification and ensures correct lifetime construction.