Skip to content

1.1 only: Address gotcha for mypy on outcome_analysis.py in Mbed TLS#758

Open
gilles-peskine-arm wants to merge 1 commit intoMbed-TLS:tf-psa-crypto-1.1from
gilles-peskine-arm:tf_psa_crypto_test_case_info-fix-mypy-1.1
Open

1.1 only: Address gotcha for mypy on outcome_analysis.py in Mbed TLS#758
gilles-peskine-arm wants to merge 1 commit intoMbed-TLS:tf-psa-crypto-1.1from
gilles-peskine-arm:tf_psa_crypto_test_case_info-fix-mypy-1.1

Conversation

@gilles-peskine-arm
Copy link
Copy Markdown
Contributor

@gilles-peskine-arm gilles-peskine-arm commented Apr 15, 2026

If we add a regex in INTERNAL_TEST_CASES in tests/scripts/tf_psa_crypto_test_case_info.py, then check_python_files from Mbed TLS's all.sh will fail unless we add a type annotation to help mypy. I did this in development in #704. Better do it preemptively in 1.1 rather than try to debug it when it comes up later.

PR checklist

  • changelog provided | not required because: test only
  • framework PR not required
  • TF-PSA-Crypto development PR was part of Make mldsa-native call the PSA SHAKE #704
  • TF-PSA-Crypto 1.1 PR here
  • mbedtls development PR provided Mbed-TLS/mbedtls# | not required because: crypto only
  • mbedtls development PR provided Mbed-TLS/mbedtls# | not required because: crypto only
  • mbedtls development PR provided Mbed-TLS/mbedtls# | not required because: crypto only
  • tests provided

Signed-off-by: Gilles Peskine <Gilles.Peskine@arm.com>
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members needs-reviewer This PR needs someone to pick it up for review size-xs Estimated task size: extra small (a few hours at most) priority-very-high Highest priority - prioritise this over other review work labels Apr 15, 2026
@gilles-peskine-arm gilles-peskine-arm changed the title 1.1 only: Fix mypy on outcome_analysis.py in Mbed TLS 1.1 only: Address gotcha for mypy on outcome_analysis.py in Mbed TLS Apr 15, 2026
@gilles-peskine-arm gilles-peskine-arm added priority-high High priority - will be reviewed soon and removed needs-reviewer This PR needs someone to pick it up for review priority-very-high Highest priority - prioritise this over other review work labels Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review Every commit must be reviewed by at least two team members priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)

Projects

Development

Successfully merging this pull request may close these issues.

2 participants