Feature/New tool: Arifact signing tool#147
Closed
minosgalanakis wants to merge 3 commits intoMbed-TLS:mainfrom
Closed
Feature/New tool: Arifact signing tool#147minosgalanakis wants to merge 3 commits intoMbed-TLS:mainfrom
minosgalanakis wants to merge 3 commits intoMbed-TLS:mainfrom
Conversation
minosgalanakis
added
enhancement
minosgalanakis
force-pushed
the
feature/fw_signer
branch
2 times, most recently
from
5b9fa5d to
184858c
Compare
This pr introduces a simple web-app to sign firmware-files using gpg. Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
minosgalanakis
force-pushed
the
feature/fw_signer
branch
from
184858c to
19f6c5c
Compare
minosgalanakis
changed the title
Signed-off-by: Minos Galanakis <minos.galanakis@arm.com>
gilles-peskine-arm
requested changes
Jul 10, 2024
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
- Since this is supposed to be on the critical path for releases, it needs to be held to a high standard of review. So it needs to be either in https://github.com/Mbed-TLS/mbedtls-framework or https://github.com/Mbed-TLS/mbedtls-test.
- Please rename it to “release signing tool”. “Artifact” is not a word we use elsewhere and you didn't even spell it consistently.
Author
|
Moved to Mbed-TLS/mbedtls-test#173 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pr is introducing the artifact sign tool, as discussed in the design review meeting.
It is a standalone tool serving a web-app and using gpg tool to sign and validate release tarballs.
How to test locally: