Skip to content

library/alignment.h: Fix 'MBEDTLS_GCC_VERSION' is not defined error#10731

Open
AmyChan-Intel wants to merge 1 commit into
Mbed-TLS:mbedtls-3.6from
AmyChan-Intel:mbedtls-3.6
Open

library/alignment.h: Fix 'MBEDTLS_GCC_VERSION' is not defined error#10731
AmyChan-Intel wants to merge 1 commit into
Mbed-TLS:mbedtls-3.6from
AmyChan-Intel:mbedtls-3.6

Conversation

@AmyChan-Intel
Copy link
Copy Markdown

@AmyChan-Intel AmyChan-Intel commented Apr 29, 2026

Description

Only check 'MBEDTLS_GCC_VERSION' when 'MBEDTLS_COMPILER_IS_GCC' is defined

PR checklist

Please remove the segment/s on either side of the | symbol as appropriate, and add any relevant link/s to the end of the line.
If the provided content is part of the present PR remove the # symbol.

  • changelog provided | not required because:
  • framework PR provided Mbed-TLS/mbedtls-framework# | not required
  • TF-PSA-Crypto development PR provided Mbed-TLS/TF-PSA-Crypto# | not required because:
  • TF-PSA-Crypto 1.1 PR provided Mbed-TLS/TF-PSA-Crypto# | not required because:
  • mbedtls development PR provided # | not required because:
  • mbedtls 4.1 PR provided # | not required because:
  • mbedtls 3.6 PR provided # | not required because:
  • tests provided | not required because:

Notes for the submitter

Please refer to the contributing guidelines, especially the
checklist for PR contributors.

Help make review efficient:

  • Multiple simple commits
    • please structure your PR into a series of small commits, each of which does one thing
  • Avoid force-push
    • please do not force-push to update your PR - just add new commit(s)
  • See our Guidelines for Contributors for more details about the review process.

@AmyChan-Intel
library/alignment.h: Fix 'MBEDTLS_GCC_VERSION' is not defined error
42c3147 
Only check 'MBEDTLS_GCC_VERSION' when 'MBEDTLS_COMPILER_IS_GCC' is defined

Signed-off-by: Amy Chan <amy.chan@intel.com>
@bensze01 bensze01 self-assigned this Apr 30, 2026
@AmyChan-Intel
Copy link
Copy Markdown
Author

AmyChan-Intel commented May 18, 2026

@bensze01 could you review this pr?

yanesca
yanesca approved these changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@yanesca yanesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yanesca
Copy link
Copy Markdown
Contributor

yanesca commented May 21, 2026

@AmyChan-Intel thank you very much for your contribution.

Do you think you could raise PRs with forward ports for this? (This file went to the crypto repo after the split so the forward ports would need to go into https://github.com/Mbed-TLS/TF-PSA-Crypto against the development and the tf-psa-crypto-1.1 branches.)

@yanesca yanesca added needs-backports Backports are missing or are pending review and approval. approved Design and code approved - may be waiting for CI or backports labels May 21, 2026
@AmyChan-Intel
Copy link
Copy Markdown
Author

AmyChan-Intel commented May 22, 2026 •
edited
Loading

@AmyChan-Intel thank you very much for your contribution.

Do you think you could raise PRs with forward ports for this? (This file went to the crypto repo after the split so the forward ports would need to go into https://github.com/Mbed-TLS/TF-PSA-Crypto against the development and the tf-psa-crypto-1.1 branches.)

@yanesca thanks a lot for the approve, could you help to merge this pr?
I can't find this file under development and the tf-psa-crypto-1.1 branches, do you know the new location of this file?

@gilles-peskine-arm
Copy link
Copy Markdown
Contributor

gilles-peskine-arm commented May 22, 2026

It moved to core/alignment.h in tf-psa-crypto

@AmyChan-Intel
Copy link
Copy Markdown
Author

AmyChan-Intel commented Jun 3, 2026

Only check 'MBEDTLS_GCC_VERSION' when 'MBEDTLS_COMPILER_IS_GCC' is defined

here is the pr link: Mbed-TLS/TF-PSA-Crypto#800

@AmyChan-Intel
Copy link
Copy Markdown
Author

AmyChan-Intel commented Jun 3, 2026

@ALL Please help to merge my pr

@yanesca
Copy link
Copy Markdown
Contributor

yanesca commented Jun 3, 2026

@AmyChan-Intel I have approved the development forward port, could you please raise the 1.1 forward port as well?

@AmyChan-Intel
Copy link
Copy Markdown
Author

AmyChan-Intel commented Jun 4, 2026

@AmyChan-Intel I have approved the development forward port, could you please raise the 1.1 forward port as well?

here is the pr link:
Mbed-TLS/TF-PSA-Crypto#801

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yanesca yanesca yanesca approved these changes

@bjwtaylor bjwtaylor bjwtaylor approved these changes

Assignees

@bensze01 bensze01

Labels

approved Design and code approved - may be waiting for CI or backports needs-backports Backports are missing or are pending review and approval.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AmyChan-Intel @yanesca @gilles-peskine-arm @bjwtaylor @bensze01