Add Indexable setting for users and magazines

- Add an option in the general settings for users and magazines to be indexable. Since it was basically the case until now, the default for local users is true.
- Add a `noindex` header if the magazine a thread or microblog belongs to, or the author of the thread or microblog are not indexable. (Note: this does not apply to comments, since they are always rendered on the thread or microblog page)
- Add the missing storage url to the `.env.test` file. This resulted in a few snapshot changes
- Add the testing services to the DI and add the arguments to only use the testing services when the environment is `test`
- improve the help text rendering underneath checkboxes and apply it to the other checkbox help text in the admin federation page

Author: BentiGorlich

.env.test

@@ -17,6 +17,7 @@ MAILER_DSN=null://default
 KBIN_JS_ENABLED=false
 KBIN_DEFAULT_LANG=en
 KBIN_DOMAIN=kbin.test
+KBIN_STORAGE_URL=https://kbin.test/media
 ELASTICSEARCH_ENABLED=false
 KBIN_API_ITEMS_PER_PAGE=2
 KBIN_FEDERATION_ENABLED=true

config/services.yaml

@@ -239,6 +239,10 @@ services:
                   event: kernel.controller_arguments,
               }
 
+    # Testing
+    App\Tests\Service\:
+        resource: '../tests/Service/'
+
     # Feeds
     debril.rss_atom.provider:
         class: App\Feed\Provider

migrations/Version20260113103210.php

@@ -0,0 +1,32 @@
+<?php
+
+declare(strict_types=1);
+
+namespace DoctrineMigrations;
+
+use Doctrine\DBAL\Schema\Schema;
+use Doctrine\Migrations\AbstractMigration;
+
+final class Version20260113103210 extends AbstractMigration
+{
+    public function getDescription(): string
+    {
+        return 'Add ap_indexable to ActivityPub actors';
+    }
+
+    public function up(Schema $schema): void
+    {
+        $this->addSql('ALTER TABLE magazine ADD ap_indexable BOOLEAN DEFAULT NULL');
+        $this->addSql('ALTER TABLE "user" ADD ap_indexable BOOLEAN DEFAULT NULL');
+        // The column should be nullable so that we know whether other software simply does not set this value,
+        // but for local users and magazines we should only have true and false as options
+        $this->addSql('UPDATE "user" SET ap_indexable = true WHERE ap_id IS NULL');
+        $this->addSql('UPDATE magazine SET ap_indexable = true WHERE ap_id IS NULL');
+    }
+
+    public function down(Schema $schema): void
+    {
+        $this->addSql('ALTER TABLE "user" DROP ap_indexable');
+        $this->addSql('ALTER TABLE magazine DROP ap_indexable');
+    }
+}

src/DTO/MagazineDto.php

@@ -40,6 +40,7 @@ class MagazineDto
     public int $postCommentCount = 0;
     public bool $isAdult = false;
     public bool $isPostingRestrictedToMods = false;
+    public ?bool $indexable = null;
     public ?bool $isUserSubscribed = null;
     public ?bool $isBlockedByUser = null;
     public ?int $localSubscribers = null;

src/DTO/MagazineRequestDto.php

@@ -16,6 +16,7 @@ class MagazineRequestDto
     public ?bool $isAdult = null;
     public ?bool $isPostingRestrictedToMods = null;
     public ?bool $discoverable = null;
+    public ?bool $indexable = null;
 
     public function mergeIntoDto(MagazineDto $dto): MagazineDto
     {
@@ -26,6 +27,7 @@ public function mergeIntoDto(MagazineDto $dto): MagazineDto
         $dto->isAdult = null !== $this->isAdult ? $this->isAdult : $dto->isAdult;
         $dto->isPostingRestrictedToMods = $this->isPostingRestrictedToMods ?? false;
         $dto->discoverable = $this->discoverable ?? $dto->discoverable ?? true;
+        $dto->indexable = $this->indexable ?? $dto->indexable ?? true;
 
         return $dto;
     }

src/DTO/MagazineResponseDto.php

@@ -41,6 +41,7 @@ class MagazineResponseDto implements \JsonSerializable
     public ?int $localSubscribers = null;
     public ?ENotificationStatus $notificationStatus = null;
     public ?bool $discoverable = null;
+    public ?bool $indexable = null;
 
     public static function create(
         ?ModeratorResponseDto $owner = null,
@@ -69,6 +70,7 @@ public static function create(
         bool $isPostingRestrictedToMods = false,
         ?int $localSubscribers = null,
         ?bool $discoverable = null,
+        ?bool $indexable = null,
     ): self {
         $dto = new MagazineResponseDto();
         $dto->owner = $owner;
@@ -97,6 +99,7 @@ public static function create(
         $dto->isPostingRestrictedToMods = $isPostingRestrictedToMods;
         $dto->localSubscribers = $localSubscribers;
         $dto->discoverable = $discoverable;
+        $dto->indexable = $indexable;
 
         return $dto;
     }
@@ -131,6 +134,7 @@ public function jsonSerialize(): mixed
             'localSubscribers' => $this->localSubscribers,
             'notificationStatus' => $this->notificationStatus,
             'discoverable' => $this->discoverable,
+            'indexable' => $this->indexable,
         ];
     }
 }

src/DTO/MagazineSmallResponseDto.php

@@ -18,6 +18,7 @@ class MagazineSmallResponseDto implements \JsonSerializable
     public ?string $apId = null;
     public ?string $apProfileId = null;
     public ?bool $discoverable = null;
+    public ?bool $indexable = null;
 
     public function __construct(MagazineDto $dto)
     {
@@ -30,6 +31,7 @@ public function __construct(MagazineDto $dto)
         $this->apId = $dto->apId;
         $this->apProfileId = $dto->apProfileId;
         $this->discoverable = $dto->discoverable;
+        $this->indexable = $dto->indexable;
     }
 
     public function jsonSerialize(): mixed
@@ -44,6 +46,7 @@ public function jsonSerialize(): mixed
             'apId' => $this->apId,
             'apProfileId' => $this->apProfileId,
             'discoverable' => $this->discoverable,
+            'indexable' => $this->indexable,
         ];
     }
 }

src/DTO/MagazineUpdateRequestDto.php

@@ -17,6 +17,7 @@ class MagazineUpdateRequestDto
     public ?bool $isAdult = null;
     public ?bool $isPostingRestrictedToMods = null;
     public ?bool $discoverable = null;
+    public ?bool $indexable = null;
 
     public function mergeIntoDto(MagazineDto $dto, ImageRepository $imageRepository): MagazineDto
     {
@@ -27,6 +28,7 @@ public function mergeIntoDto(MagazineDto $dto, ImageRepository $imageRepository)
         $dto->isAdult = null === $this->isAdult ? $this->isAdult : $dto->isAdult;
         $dto->isPostingRestrictedToMods = $this->isPostingRestrictedToMods ?? false;
         $dto->discoverable = $this->discoverable ?? $dto->discoverable ?? true;
+        $dto->indexable = $this->indexable ?? $dto->indexable ?? true;
 
         return $dto;
     }

src/DTO/UserDto.php

@@ -52,6 +52,7 @@ class UserDto implements UserDtoInterface
     public ?string $applicationText = null;
     public ?int $reputationPoints = null;
     public ?bool $discoverable = null;
+    public ?bool $indexable = null;
 
     #[Assert\Callback]
     public function validate(
@@ -97,6 +98,7 @@ public static function create(
         ?string $applicationText = null,
         ?int $reputationPoints = null,
         ?bool $discoverable = null,
+        ?bool $indexable = null,
     ): self {
         $dto = new UserDto();
         $dto->id = $id;
@@ -116,6 +118,7 @@ public static function create(
         $dto->applicationText = $applicationText;
         $dto->reputationPoints = $reputationPoints;
         $dto->discoverable = $discoverable;
+        $dto->indexable = $indexable;
 
         return $dto;
     }

src/DTO/UserResponseDto.php

@@ -28,6 +28,7 @@ class UserResponseDto implements \JsonSerializable
     public ?string $serverSoftware = null;
     public ?string $serverSoftwareVersion = null;
     public ?ENotificationStatus $notificationStatus = null;
+    public ?bool $indexable = null;
 
     /**
      * @var int|null this will only be populated on single user retrieves, not on batch ones,
@@ -57,6 +58,7 @@ public function __construct(UserDto $dto)
         $this->isGlobalModerator = $dto->isGlobalModerator;
         $this->reputationPoints = $dto->reputationPoints;
         $this->discoverable = $dto->discoverable;
+        $this->indexable = $dto->indexable;
     }
 
     public function jsonSerialize(): mixed
@@ -82,6 +84,7 @@ public function jsonSerialize(): mixed
             'notificationStatus' => $this->notificationStatus,
             'reputationPoints' => $this->reputationPoints,
             'discoverable' => $this->discoverable,
+            'indexable' => $this->indexable,
         ];
     }
 }