Skip to content

Commit 24243e3

Browse files
SkyZeroZxthePunderWoman
authored andcommitted
refactor(common): removes unused NgModuleFactory config in NgComponentOutlet
Removes the `ngComponentOutletNgModuleFactory` in `_needToReCreateNgModuleInstance`
1 parent 1aed940 commit 24243e3

1 file changed

Lines changed: 1 addition & 7 deletions

File tree

packages/common/src/directives/ng_component_outlet.ts

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,6 @@ import {
5050
* * `ngComponentOutletNgModule`: Optional NgModule class reference to allow loading another
5151
* module dynamically, then loading a component from that module.
5252
*
53-
* * `ngComponentOutletNgModuleFactory`: Deprecated config option that allows providing optional
54-
* NgModule factory to allow loading another module dynamically, then loading a component from that
55-
* module. Use `ngComponentOutletNgModule` instead.
5653
*
5754
* ### Syntax
5855
*
@@ -133,10 +130,7 @@ export class NgComponentOutlet<T = any> implements OnChanges, DoCheck, OnDestroy
133130
// Note: square brackets property accessor is safe for Closure compiler optimizations (the
134131
// `changes` argument of the `ngOnChanges` lifecycle hook retains the names of the fields that
135132
// were changed).
136-
return (
137-
changes['ngComponentOutletNgModule'] !== undefined ||
138-
changes['ngComponentOutletNgModuleFactory'] !== undefined
139-
);
133+
return changes['ngComponentOutletNgModule'] !== undefined;
140134
}
141135

142136
private _needToReCreateComponentInstance(changes: SimpleChanges): boolean {

0 commit comments

Comments
 (0)