Skip to content

Commit 96b79fc

Browse files
Anuj-Chhajedalxhub
authored andcommitted
refactor(core): correct all typeof ngDevMode comparison patterns introduced by angular#63875
This change replaces all remaining occurrences of `typeof ngDevMode !== undefined` with the correct `typeof ngDevMode !== 'undefined'` form. This aligns the codebase with JavaScript typeof semantics and maintains consistency with other Angular code.
1 parent efde94a commit 96b79fc

40 files changed

Lines changed: 58 additions & 58 deletions

packages/common/http/src/interceptor.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,29 +192,29 @@ export function chainedInterceptorFn(
192192
* @publicApi
193193
*/
194194
export const HTTP_INTERCEPTORS = new InjectionToken<readonly HttpInterceptor[]>(
195-
typeof ngDevMode !== undefined && ngDevMode ? 'HTTP_INTERCEPTORS' : '',
195+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'HTTP_INTERCEPTORS' : '',
196196
);
197197

198198
/**
199199
* A multi-provided token of `HttpInterceptorFn`s.
200200
*/
201201
export const HTTP_INTERCEPTOR_FNS = new InjectionToken<readonly HttpInterceptorFn[]>(
202-
typeof ngDevMode !== undefined && ngDevMode ? 'HTTP_INTERCEPTOR_FNS' : '',
202+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'HTTP_INTERCEPTOR_FNS' : '',
203203
{factory: () => []},
204204
);
205205

206206
/**
207207
* A multi-provided token of `HttpInterceptorFn`s that are only set in root.
208208
*/
209209
export const HTTP_ROOT_INTERCEPTOR_FNS = new InjectionToken<readonly HttpInterceptorFn[]>(
210-
typeof ngDevMode !== undefined && ngDevMode ? 'HTTP_ROOT_INTERCEPTOR_FNS' : '',
210+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'HTTP_ROOT_INTERCEPTOR_FNS' : '',
211211
);
212212

213213
// TODO(atscott): We need a larger discussion about stability and what should contribute to stability.
214214
// Should the whole interceptor chain contribute to stability or just the backend request #55075?
215215
// Should HttpClient contribute to stability automatically at all?
216216
export const REQUESTS_CONTRIBUTE_TO_STABILITY = new InjectionToken<boolean>(
217-
typeof ngDevMode !== undefined && ngDevMode ? 'REQUESTS_CONTRIBUTE_TO_STABILITY' : '',
217+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'REQUESTS_CONTRIBUTE_TO_STABILITY' : '',
218218
{providedIn: 'root', factory: () => true},
219219
);
220220

packages/common/http/src/provider.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ export function withInterceptors(
156156
}
157157

158158
const LEGACY_INTERCEPTOR_FN = new InjectionToken<HttpInterceptorFn>(
159-
typeof ngDevMode !== undefined && ngDevMode ? 'LEGACY_INTERCEPTOR_FN' : '',
159+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'LEGACY_INTERCEPTOR_FN' : '',
160160
);
161161

162162
/**

packages/common/http/src/transfer_cache.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ export type HttpTransferCacheOptions = {
8181
* @publicApi
8282
*/
8383
export const HTTP_TRANSFER_CACHE_ORIGIN_MAP = new InjectionToken<Record<string, string>>(
84-
typeof ngDevMode !== undefined && ngDevMode ? 'HTTP_TRANSFER_CACHE_ORIGIN_MAP' : '',
84+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'HTTP_TRANSFER_CACHE_ORIGIN_MAP' : '',
8585
);
8686

8787
/**
@@ -115,7 +115,7 @@ interface CacheOptions extends HttpTransferCacheOptions {
115115
}
116116

117117
const CACHE_OPTIONS = new InjectionToken<CacheOptions>(
118-
typeof ngDevMode !== undefined && ngDevMode ? 'HTTP_TRANSFER_STATE_CACHE_OPTIONS' : '',
118+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'HTTP_TRANSFER_STATE_CACHE_OPTIONS' : '',
119119
);
120120

121121
/**

packages/common/http/src/xsrf.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -22,15 +22,15 @@ import {HttpRequest} from './request';
2222
import {HttpEvent} from './response';
2323

2424
export const XSRF_ENABLED = new InjectionToken<boolean>(
25-
typeof ngDevMode !== undefined && ngDevMode ? 'XSRF_ENABLED' : '',
25+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'XSRF_ENABLED' : '',
2626
{
2727
factory: () => true,
2828
},
2929
);
3030

3131
export const XSRF_DEFAULT_COOKIE_NAME = 'XSRF-TOKEN';
3232
export const XSRF_COOKIE_NAME = new InjectionToken<string>(
33-
typeof ngDevMode !== undefined && ngDevMode ? 'XSRF_COOKIE_NAME' : '',
33+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'XSRF_COOKIE_NAME' : '',
3434
{
3535
providedIn: 'root',
3636
factory: () => XSRF_DEFAULT_COOKIE_NAME,
@@ -39,7 +39,7 @@ export const XSRF_COOKIE_NAME = new InjectionToken<string>(
3939

4040
export const XSRF_DEFAULT_HEADER_NAME = 'X-XSRF-TOKEN';
4141
export const XSRF_HEADER_NAME = new InjectionToken<string>(
42-
typeof ngDevMode !== undefined && ngDevMode ? 'XSRF_HEADER_NAME' : '',
42+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'XSRF_HEADER_NAME' : '',
4343
{
4444
providedIn: 'root',
4545
factory: () => XSRF_DEFAULT_HEADER_NAME,

packages/common/src/directives/ng_optimized_image/image_loaders/image_loader.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -71,7 +71,7 @@ export type ImageLoaderInfo = {
7171
* @publicApi
7272
*/
7373
export const IMAGE_LOADER = new InjectionToken<ImageLoader>(
74-
typeof ngDevMode !== undefined && ngDevMode ? 'ImageLoader' : '',
74+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'ImageLoader' : '',
7575
{
7676
factory: () => noopImageLoader,
7777
},

packages/common/src/directives/ng_optimized_image/preconnect_link_checker.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ const INTERNAL_PRECONNECT_CHECK_BLOCKLIST = new Set(['localhost', '127.0.0.1', '
4343
* @publicApi
4444
*/
4545
export const PRECONNECT_CHECK_BLOCKLIST = new InjectionToken<Array<string | string[]>>(
46-
typeof ngDevMode !== undefined && ngDevMode ? 'PRECONNECT_CHECK_BLOCKLIST' : '',
46+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'PRECONNECT_CHECK_BLOCKLIST' : '',
4747
);
4848

4949
/**

packages/common/src/location/location_strategy.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ export abstract class LocationStrategy {
7676
* @publicApi
7777
*/
7878
export const APP_BASE_HREF = new InjectionToken<string>(
79-
typeof ngDevMode !== undefined && ngDevMode ? 'appBaseHref' : '',
79+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'appBaseHref' : '',
8080
);
8181

8282
/**

packages/common/src/location/platform_location.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ export abstract class PlatformLocation {
7373
* @publicApi
7474
*/
7575
export const LOCATION_INITIALIZED = new InjectionToken<Promise<any>>(
76-
typeof ngDevMode !== undefined && ngDevMode ? 'Location Initialized' : '',
76+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'Location Initialized' : '',
7777
);
7878

7979
/**

packages/common/src/pipes/date_pipe.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ import {invalidPipeArgumentError} from './invalid_pipe_argument_error';
2020
* @deprecated use DATE_PIPE_DEFAULT_OPTIONS token to configure DatePipe
2121
*/
2222
export const DATE_PIPE_DEFAULT_TIMEZONE = new InjectionToken<string>(
23-
typeof ngDevMode !== undefined && ngDevMode ? 'DATE_PIPE_DEFAULT_TIMEZONE' : '',
23+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'DATE_PIPE_DEFAULT_TIMEZONE' : '',
2424
);
2525

2626
/**
@@ -55,7 +55,7 @@ export const DATE_PIPE_DEFAULT_TIMEZONE = new InjectionToken<string>(
5555
* ```
5656
*/
5757
export const DATE_PIPE_DEFAULT_OPTIONS = new InjectionToken<DatePipeConfig>(
58-
typeof ngDevMode !== undefined && ngDevMode ? 'DATE_PIPE_DEFAULT_OPTIONS' : '',
58+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'DATE_PIPE_DEFAULT_OPTIONS' : '',
5959
);
6060

6161
/**

packages/common/upgrade/src/location_upgrade_module.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,11 +56,11 @@ export interface LocationUpgradeConfig {
5656
* @publicApi
5757
*/
5858
export const LOCATION_UPGRADE_CONFIGURATION = new InjectionToken<LocationUpgradeConfig>(
59-
typeof ngDevMode !== undefined && ngDevMode ? 'LOCATION_UPGRADE_CONFIGURATION' : '',
59+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'LOCATION_UPGRADE_CONFIGURATION' : '',
6060
);
6161

6262
const APP_BASE_HREF_RESOLVED = new InjectionToken<string>(
63-
typeof ngDevMode !== undefined && ngDevMode ? 'APP_BASE_HREF_RESOLVED' : '',
63+
typeof ngDevMode !== 'undefined' && ngDevMode ? 'APP_BASE_HREF_RESOLVED' : '',
6464
);
6565

6666
/**

0 commit comments

Comments
 (0)