Allow binding to specific IP address#336
Open
andy5995 wants to merge 1 commit into
Open
Conversation
andy5995
force-pushed
the
feat/bind-ip-iss-264
branch
5 times, most recently
from
March 28, 2025 02:57
1f7a7cc to
5be46cf
Compare
andy5995
marked this pull request as ready for review
March 28, 2025 03:05
andy5995
force-pushed
the
feat/bind-ip-iss-264
branch
2 times, most recently
from
March 28, 2025 17:56
59d4f52 to
d952b7e
Compare
closes #264 Add server bind address field to network options
andy5995
force-pushed
the
feat/bind-ip-iss-264
branch
2 times, most recently
from
March 29, 2025 04:35
08d1ed6 to
27c8121
Compare
andy5995
marked this pull request as draft
March 29, 2025 05:04
Contributor
Author
|
I screwed up rebasing. This is not ready for review now. |
Jammyjamjamman
force-pushed
the
feat/bind-ip-iss-264
branch
from
March 29, 2025 19:25
27c8121 to
08d1ed6
Compare
andy5995
marked this pull request as ready for review
March 29, 2025 20:01
Contributor
Author
|
This is ready for review again. The merge conflicts are due to the new code formatting in develop and I'll fix them... later. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #264
@tomreyn This makes binding configurable via a command line option or from glestuser.ini by adding
ServerBindAddress=....manually or through the Network options screen.
I've only tested this using my LAN IP.