fix: bug fixes and menu bar popup positioning

- ApplicationsManagerView, DevCleanerView, PerformanceManagerView,
  PrivacyView: remove scanAll() call from OK/Done dismiss buttons;
  add Full Disk Access alert when 0 bytes cleaned; track actual bytes
  deleted instead of planned bytes (PrivacyView)
- MenuBarView: add MenuBarPopupPositioner — forces menu bar popup to
  top-right corner on every open using NSWindow.didBecomeKeyNotification
  so it persists across repeated clicks
- MacSweepApp: restore main window to center positioning

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

Author: MehmedHunjra

MacSweep/ApplicationsManagerView.swift

@@ -36,6 +36,7 @@ struct ApplicationsManagerView: View {
     @State private var showClearAllConfirm = false
     @State private var showResult = false
     @State private var resultMessage = ""
+    @State private var showFDAAlert = false
     @State private var searchText = ""
     @State private var activeFilter: AppFilter = .all
     @State private var activeSort: AppSort = .name
@@ -137,10 +138,18 @@ struct ApplicationsManagerView: View {
             }
         }
         .alert("Action Complete", isPresented: $showResult) {
-            Button("OK") { engine.scanAll() }
+            Button("OK") { }
         } message: {
             Text(resultMessage)
         }
+        .alert("Full Disk Access Required", isPresented: $showFDAAlert) {
+            Button("Open System Settings") {
+                NSWorkspace.shared.open(URL(string: "x-apple.systempreferences:com.apple.preference.security?Privacy_AllFiles")!)
+            }
+            Button("Cancel", role: .cancel) { }
+        } message: {
+            Text("MacSweep needs Full Disk Access to clean app files.\n\nGo to System Settings → Privacy & Security → Full Disk Access and enable MacSweep.")
+        }
     }
 
     // MARK: - Landing
@@ -877,8 +886,12 @@ struct ApplicationsManagerView: View {
                 .confirmationDialog("Clean All App Leftovers?", isPresented: $showBatchCleanConfirm, titleVisibility: .visible) {
                     Button("Clean Selected Leftovers from \(appsWithLeftovers) Apps", role: .destructive) {
                         let cleaned = engine.batchCleanAllLeftovers()
-                        resultMessage = "Batch cleaned \(ByteCountFormatter.string(fromByteCount: cleaned, countStyle: .file)) from \(appsWithLeftovers) apps."
-                        showResult = true
+                        if cleaned == 0 {
+                            showFDAAlert = true
+                        } else {
+                            resultMessage = "Cleaned \(ByteCountFormatter.string(fromByteCount: cleaned, countStyle: .file)) from \(appsWithLeftovers) apps."
+                            showResult = true
+                        }
                     }
                     Button("Cancel", role: .cancel) {}
                 } message: {
@@ -922,8 +935,12 @@ struct ApplicationsManagerView: View {
                 .confirmationDialog("Reset \(app.name)?", isPresented: $showResetConfirm, titleVisibility: .visible) {
                     Button("Reset (Delete Leftovers)", role: .destructive) {
                         let cleaned = engine.resetApp(appId: app.id)
-                        resultMessage = "Cleaned \(ByteCountFormatter.string(fromByteCount: cleaned, countStyle: .file)) of data from \(app.name)."
-                        showResult = true
+                        if cleaned == 0 {
+                            showFDAAlert = true
+                        } else {
+                            resultMessage = "Cleaned \(ByteCountFormatter.string(fromByteCount: cleaned, countStyle: .file)) from \(app.name)."
+                            showResult = true
+                        }
                     }
                     Button("Cancel", role: .cancel) {}
                 }
@@ -944,8 +961,12 @@ struct ApplicationsManagerView: View {
                 .confirmationDialog("Clear All App Data for \(app.name)?", isPresented: $showClearAllConfirm, titleVisibility: .visible) {
                     Button("Deep Clean (Delete Leftovers + Scratch)", role: .destructive) {
                         let cleaned = engine.clearAllAppData(appId: app.id)
-                        resultMessage = "Deep cleaned \(ByteCountFormatter.string(fromByteCount: cleaned, countStyle: .file)) from \(app.name)."
-                        showResult = true
+                        if cleaned == 0 {
+                            showFDAAlert = true
+                        } else {
+                            resultMessage = "Deep cleaned \(ByteCountFormatter.string(fromByteCount: cleaned, countStyle: .file)) from \(app.name)."
+                            showResult = true
+                        }
                     }
                     Button("Cancel", role: .cancel) {}
                 } message: { Text("This will move ALL detected caches, logs, preferences, and temporary files for this app to Trash when possible.") }

MacSweep/DevCleanerView.swift

@@ -10,6 +10,7 @@ struct DevCleanerView: View {
     @State private var cleanedBytes: Int64 = 0
     @State private var showCleanSheet = false
     @State private var showResultSheet = false
+    @State private var showFDAAlert = false
     @State private var showNodeModulesSheet = false
     @State private var showBuildArtifactsSheet = false
     @State private var showCLIToolsSheet = false
@@ -451,7 +452,11 @@ struct DevCleanerView: View {
                         isCleaning = true
                         cleanedBytes = await devEngine.cleanSelected()
                         isCleaning = false
-                        showResultSheet = true
+                        if cleanedBytes == 0 {
+                            showFDAAlert = true
+                        } else {
+                            showResultSheet = true
+                        }
                     }
                 }
                 Button("Cancel", role: .cancel) {}
@@ -461,9 +466,16 @@ struct DevCleanerView: View {
             .sheet(isPresented: $showResultSheet) {
                 DevCleanResultSheet(cleanedBytes: cleanedBytes) {
                     showResultSheet = false
-                    devEngine.scanAll()
                 }
             }
+            .alert("Full Disk Access Required", isPresented: $showFDAAlert) {
+                Button("Open System Settings") {
+                    NSWorkspace.shared.open(URL(string: "x-apple.systempreferences:com.apple.preference.security?Privacy_AllFiles")!)
+                }
+                Button("Cancel", role: .cancel) { }
+            } message: {
+                Text("MacSweep needs Full Disk Access to delete dev caches.\n\nGo to System Settings → Privacy & Security → Full Disk Access and enable MacSweep.")
+            }
         }
         .padding(.horizontal, 20)
         .padding(.vertical, 12)

MacSweep/MacSweepApp.swift

@@ -133,6 +133,7 @@ class AppDelegate: NSObject, NSApplicationDelegate {
 
         guard needsResize else { return }
 
+        // Position window in the center of the screen
         let targetRect = NSRect(
             x: visible.midX - targetWidth / 2,
             y: visible.midY - targetHeight / 2,

MacSweep/MenuBarView.swift

@@ -133,6 +133,7 @@ struct MenuBarView: View {
         }
         .frame(width: 840)
         .background(bgGradient)
+        .background(MenuBarPopupPositioner())
         .animation(.easeInOut(duration: 0.22), value: settings.menuBarTab)
         .onReceive(Timer.publish(every: 3.0, on: .main, in: .common).autoconnect()) { _ in
             // Keep menu popup values fresh while it is open.
@@ -3114,3 +3115,52 @@ struct MenuBarStatusRow: View {
         }
     }
 }
+
+// MARK: - Menu Bar Popup Positioner
+// Moves the MenuBarExtra popup window to the top-right corner every time it opens.
+private struct MenuBarPopupPositioner: NSViewRepresentable {
+    func makeNSView(context: Context) -> NSView {
+        let view = _PositionerView()
+        return view
+    }
+    func updateNSView(_ nsView: NSView, context: Context) {}
+}
+
+private final class _PositionerView: NSView {
+    private var observer: NSObjectProtocol?
+
+    override func viewDidMoveToWindow() {
+        super.viewDidMoveToWindow()
+        guard let window else { return }
+        positionTopRight(window)
+
+        // Re-position every time the popup becomes key (i.e. every click on the icon)
+        observer = NotificationCenter.default.addObserver(
+            forName: NSWindow.didBecomeKeyNotification,
+            object: window,
+            queue: .main
+        ) { [weak window] _ in
+            guard let window else { return }
+            self.positionTopRight(window)
+        }
+    }
+
+    override func removeFromSuperview() {
+        if let observer { NotificationCenter.default.removeObserver(observer) }
+        super.removeFromSuperview()
+    }
+
+    private func positionTopRight(_ window: NSWindow) {
+        for delay in [0.05, 0.15, 0.3] {
+            DispatchQueue.main.asyncAfter(deadline: .now() + delay) { [weak window] in
+                guard let window, window.isVisible else { return }
+                guard let screen = window.screen ?? NSScreen.main else { return }
+                let visible = screen.visibleFrame
+                let size = window.frame.size
+                let x = visible.maxX - size.width - 8
+                let y = visible.maxY - size.height
+                window.setFrameOrigin(NSPoint(x: x, y: y))
+            }
+        }
+    }
+}

MacSweep/PerformanceManagerView.swift

@@ -8,6 +8,7 @@ struct PerformanceManagerView: View {
     @State private var selectedGroup: PerformanceGroup.Kind? = .loginItems
     @State private var showResult = false
     @State private var resultMessage = ""
+    @State private var showFDAAlert = false
 
     @EnvironmentObject var navManager: NavigationManager
 
@@ -62,10 +63,18 @@ struct PerformanceManagerView: View {
         }
         .background(DS.bg)
         .alert("Action Complete", isPresented: $showResult) {
-            Button("OK") { engine.scanAll() }
+            Button("OK") { }
         } message: {
             Text(resultMessage)
         }
+        .alert("Full Disk Access Required", isPresented: $showFDAAlert) {
+            Button("Open System Settings") {
+                NSWorkspace.shared.open(URL(string: "x-apple.systempreferences:com.apple.preference.security?Privacy_AllFiles")!)
+            }
+            Button("Cancel", role: .cancel) { }
+        } message: {
+            Text("MacSweep needs Full Disk Access to manage startup items.\n\nGo to System Settings → Privacy & Security → Full Disk Access and enable MacSweep.")
+        }
     }
 
     // MARK: - Landing

MacSweep/PrivacyView.swift

@@ -5,6 +5,7 @@ struct PrivacyView: View {
     @ObservedObject var cleanEngine: CleanEngine
     @State private var showConfirm  = false
     @State private var showResult   = false
+    @State private var showFDAAlert = false
     @State private var isScanning   = false
     @State private var privacyItems: [PrivacyItem] = []
     @State private var scanDone     = false
@@ -44,6 +45,14 @@ struct PrivacyView: View {
         } message: {
             Text("This will clear \(ByteCountFormatter.string(fromByteCount: selectedSize, countStyle: .file)) of privacy-sensitive data.")
         }
+        .alert("Full Disk Access Required", isPresented: $showFDAAlert) {
+            Button("Open System Settings") {
+                NSWorkspace.shared.open(URL(string: "x-apple.systempreferences:com.apple.preference.security?Privacy_AllFiles")!)
+            }
+            Button("Cancel", role: .cancel) { }
+        } message: {
+            Text("MacSweep needs Full Disk Access to clear privacy data.\n\nGo to System Settings → Privacy & Security → Full Disk Access and enable MacSweep.")
+        }
     }
 
     // MARK: - Scanning View
@@ -230,17 +239,25 @@ struct PrivacyView: View {
     }
 
     private func clearPrivacyData() {
-        let bytesToClear = selectedSize
         let fm = FileManager.default
+        var actualCleared: Int64 = 0
         for item in privacyItems where item.isSelected {
             let url = URL(fileURLWithPath: item.path)
-            if (try? fm.trashItem(at: url, resultingItemURL: nil)) == nil {
-                try? fm.removeItem(at: url)
+            let deleted: Bool
+            if (try? fm.trashItem(at: url, resultingItemURL: nil)) != nil {
+                deleted = true
+            } else if (try? fm.removeItem(at: url)) != nil {
+                deleted = true
+            } else {
+                deleted = false
             }
+            if deleted { actualCleared += item.size }
         }
-        if bytesToClear > 0 {
-            scanEngine.recordFreed(bytes: bytesToClear, description: "Privacy cleanup")
+        if actualCleared == 0 {
+            showFDAAlert = true
+            return
         }
+        scanEngine.recordFreed(bytes: actualCleared, description: "Privacy cleanup")
         DS.playCleanComplete()
         scanPrivacy()
     }