Skip to content

fix: handle string input in _get_further_suggestion #1218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JasonOA888 wants to merge 2 commits into from
Closed

fix: handle string input in _get_further_suggestion #1218

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5ec009
fix: handle string input in _get_further_suggestion for backward comp…
JasonOA888 Mar 12, 2026
31d9cbd
Merge branch 'dev-20260323-v2.0.11' into fix/suggestion-typeerror-str…
CaralHsi Mar 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 6 additions & 10 deletions src/memos/api/handlers/suggestion_handler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,22 +32,18 @@ def _get_further_suggestion(

Args:
llm: LLM instance for generating suggestions
message: Recent chat messages (can be a list of message dicts or a plain string)
message: Recent chat messages (MessageList or string for backward compatibility)

Returns:
List of suggestion queries
"""
try:
# Handle backward compatibility: convert string to MessageList format
if isinstance(message, str):
dialogue_info = message
else:
dialogue_info = "\n".join(
[
f"{msg['role']}: {msg['content']}"
for msg in message[-2:]
if isinstance(msg, dict)
]
)
logger.warning("Received string message, converting to MessageList format")
message = [{"role": "user", "content": message}]

dialogue_info = "\n".join([f"{msg['role']}: {msg['content']}" for msg in message[-2:]])
further_suggestion_prompt = FURTHER_SUGGESTION_PROMPT.format(dialogue=dialogue_info)
message_list = [{"role": "system", "content": further_suggestion_prompt}]
response = llm.generate(message_list)
Expand Down
Loading