Skip to content

fix(install): handle postinstall node_modules cleanup and remove stale contextEngine slot #1399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hijzy merged 2 commits into from
Apr 2, 2026
Merged

fix(install): handle postinstall node_modules cleanup and remove stale contextEngine slot #1399

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cbb1d6d
fix(install): handle postinstall node_modules cleanup and remove stal…
hijzy Apr 2, 2026
ac01aa6
Merge branch 'main' into fix/install-cleanup-stale-config
hijzy Apr 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 20 additions & 3 deletions apps/memos-local-openclaw/install.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,10 +184,13 @@ if (!config.plugins.allow.includes(pluginId)) {
config.plugins.allow.push(pluginId);
}

if (!config.plugins.slots || typeof config.plugins.slots !== "object") {
config.plugins.slots = {};
// Clean up stale contextEngine slot from previous versions
if (config.plugins.slots && config.plugins.slots.contextEngine) {
delete config.plugins.slots.contextEngine;
if (Object.keys(config.plugins.slots).length === 0) {
delete config.plugins.slots;
}
}
config.plugins.slots.contextEngine = "memos-local-openclaw-plugin";

fs.writeFileSync(configPath, `${JSON.stringify(config, null, 2)}\n`, "utf8");
'@
Expand Down Expand Up @@ -298,6 +301,20 @@ finally {
Pop-Location
}

$nodeModulesDir = Join-Path $ExtensionDir "node_modules"
if (-not (Test-Path $nodeModulesDir) -or @(Get-ChildItem -Path $nodeModulesDir -ErrorAction SilentlyContinue).Count -eq 0) {
Write-Warn "node_modules was cleaned by postinstall (version upgrade detected), re-installing..."
Push-Location $ExtensionDir
try {
$env:MEMOS_SKIP_SETUP = "1"
& npm install --omit=dev --no-fund --no-audit --loglevel=error 2>&1
}
finally {
Remove-Item Env:\MEMOS_SKIP_SETUP -ErrorAction SilentlyContinue
Pop-Location
}
}

if (-not (Test-Path $ExtensionDir)) {
Write-Err "Plugin directory not found after install: $ExtensionDir"
exit 1
Expand Down
17 changes: 14 additions & 3 deletions apps/memos-local-openclaw/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,10 +246,13 @@ if (!config.plugins.allow.includes(pluginId)) {
config.plugins.allow.push(pluginId);
}

if (!config.plugins.slots || typeof config.plugins.slots !== 'object') {
config.plugins.slots = {};
// Clean up stale contextEngine slot from previous versions
if (config.plugins.slots && config.plugins.slots.contextEngine) {
delete config.plugins.slots.contextEngine;
if (Object.keys(config.plugins.slots).length === 0) {
delete config.plugins.slots;
}
}
config.plugins.slots.contextEngine = 'memos-local-openclaw-plugin';

fs.writeFileSync(configPath, `${JSON.stringify(config, null, 2)}\n`, 'utf8');
NODE
Expand Down Expand Up @@ -305,6 +308,14 @@ info "Install dependencies, 安装依赖..."
MEMOS_SKIP_SETUP=1 npm install --omit=dev --no-fund --no-audit --loglevel=error 2>&1
)

if [[ ! -d "${EXTENSION_DIR}/node_modules" ]] || [[ -z "$(ls -A "${EXTENSION_DIR}/node_modules" 2>/dev/null)" ]]; then
warn "node_modules was cleaned by postinstall (version upgrade detected), re-installing..."
(
cd "${EXTENSION_DIR}"
MEMOS_SKIP_SETUP=1 npm install --omit=dev --no-fund --no-audit --loglevel=error 2>&1
)
fi

if [[ ! -d "$EXTENSION_DIR" ]]; then
error "Plugin directory not found after install, 安装后未找到插件目录: ${EXTENSION_DIR}"
exit 1
Expand Down
Loading