Fix code style issues using Claude Code

Author: MeowServer

HintServiceMeow.Benchmarks/Benchmarks/HintParserBenchmark.cs

@@ -37,12 +37,12 @@ public IEnumerable<HintParams> GetParameters()
 
         public const float AspectRatio = 16f / 9f;
 
-        public List<Hint> hints;
-        public List<DynamicHint> dynamicHints;
-        public HintParserArgument hintArg;
-        public HintParserArgument hintOnlyArg;
-        public HintParserArgument dynamicHintOnlyArg;
-        public List<string> testRichTexts;
+        public List<Hint> hints = null!;
+        public List<DynamicHint> dynamicHints = null!;
+        public HintParserArgument hintArg = null!;
+        public HintParserArgument hintOnlyArg = null!;
+        public HintParserArgument dynamicHintOnlyArg = null!;
+        public List<string> testRichTexts = null!;
 
         // Use GlobalSetup instead of the constructor. BenchmarkDotNet calls this 
         // AFTER injecting the parameters but BEFORE the benchmark starts.

HintServiceMeow.Benchmarks/Benchmarks/RichTextParserBenchmark.cs

@@ -22,9 +22,9 @@ namespace HintServiceMeow.Benchmarks.Benchmarks
     [CategoriesColumn]
     public class PhaseBenchmark
     {
-        private string testInput;
-        private RichTextParserSetting setting;
-        private RichTextParser parser;
+        private string testInput = null!;
+        private RichTextParserSetting setting = null!;
+        private RichTextParser parser = null!;
 
         // Sink fields — prevent JIT from optimizing away the entire call
         private int sink;
@@ -81,16 +81,16 @@ public void TokenizeOnly()
     [MemoryDiagnoser]
     public class InputProfileBenchmark
     {
-        private string plainText;
-        private string tagHeavy;
-        private string longSingleLine;
-        private string manyShortLines;
-        private string nestedStyles;
-        private string colorHeavy;
-        private string realWorldMixed;
-
-        private RichTextParserSetting setting;
-        private RichTextParser parser;
+        private string plainText = null!;
+        private string tagHeavy = null!;
+        private string longSingleLine = null!;
+        private string manyShortLines = null!;
+        private string nestedStyles = null!;
+        private string colorHeavy = null!;
+        private string realWorldMixed = null!;
+
+        private RichTextParserSetting setting = null!;
+        private RichTextParser parser = null!;
         private int sink;
 
         [GlobalSetup]
@@ -290,8 +290,8 @@ public void TokenizerPool_RentReturn()
     [MemoryDiagnoser]
     public class AllocationBenchmark
     {
-        private RichTextParserSetting setting;
-        private RichTextParser parser;
+        private RichTextParserSetting setting = null!;
+        private RichTextParser parser = null!;
         private int sink;
 
         [GlobalSetup]
@@ -368,9 +368,9 @@ public class ScalabilityBenchmark
         [Params(1, 5, 10, 50, 100)]
         public int Scale;
 
-        private string scaledInput;
-        private RichTextParserSetting setting;
-        private RichTextParser parser;
+        private string scaledInput = null!;
+        private RichTextParserSetting setting = null!;
+        private RichTextParser parser = null!;
         private int sink;
 
         [GlobalSetup]
@@ -410,10 +410,10 @@ public void Parse_Scaled()
     [MemoryDiagnoser]
     public class IgnoreTagsBenchmark
     {
-        private string testInput;
-        private RichTextParserSetting settingNoIgnore;
-        private RichTextParserSetting settingWithIgnore;
-        private RichTextParser parser;
+        private string testInput = null!;
+        private RichTextParserSetting settingNoIgnore = null!;
+        private RichTextParserSetting settingWithIgnore = null!;
+        private RichTextParser parser = null!;
         private int sink;
 
         [GlobalSetup]
@@ -471,8 +471,8 @@ public void WithIgnoreTags()
     [MemoryDiagnoser]
     public class PoolEffectBenchmark
     {
-        private string testInput;
-        private RichTextParserSetting setting;
+        private string testInput = null!;
+        private RichTextParserSetting setting = null!;
         private int sink;
 
         [GlobalSetup]

HintServiceMeow.Tests/Core/Utilities/Pools/RichTextParserPoolTests.cs

@@ -109,7 +109,7 @@ public void Return_DoesNotClearParserState_FontSizeStack()
 
         /// <summary>
         /// [BUG DETECTION] Return() does not call ClearStatus() on the parser.
-        /// Expected: After Return and Rent, parser style should be TextStyle.Normal.
+        /// Expected: After Return and Rent, parser style should be FontStyle.Normal.
         /// Actual: Style from previous use is retained.
         /// </summary>
         [TestMethod]
@@ -119,16 +119,16 @@ public void Return_DoesNotClearParserState_StyleField()
             // Arrange
             RichTextParserPool pool = RichTextParserPool.Instance;
             RichTextParser parser = pool.Rent();
-            ReflectionHelper.SetFieldValue(parser, "style", TextStyle.Bold);
+            ReflectionHelper.SetFieldValue(parser, "style", FontStyle.Bold);
 
             // Act
             pool.Return(parser);
             RichTextParser reused = pool.Rent();
 
             // Assert
-            TextStyle style = ReflectionHelper.GetFieldValue<TextStyle>(reused, "style");
+            FontStyle style = ReflectionHelper.GetFieldValue<FontStyle>(reused, "style");
             // If this PASSES (style == Normal), the bug is fixed.
-            Assert.AreEqual(TextStyle.Normal, style,
+            Assert.AreEqual(FontStyle.Normal, style,
                 "[BUG] Parser style field not cleared on Return — state leaks between uses");
         }
 

HintServiceMeow/Core/Enum/FontStyle.cs

@@ -1,9 +1,12 @@
-namespace HintServiceMeow.Core.Enum
+namespace HintServiceMeow.Core.Enum
 {
     using System;
 
+    /// <summary>
+    /// Specifies the font style applied to text, supporting bold and italic as flags.
+    /// </summary>
     [Flags]
-    internal enum TextStyle
+    internal enum FontStyle
     {
         Normal = 0x0000,
         Bold = 0x0001,

HintServiceMeow/Core/Extension/WrapModeExtension.cs

@@ -24,7 +24,7 @@ public static HsmWrapMode ToHsmWrapMode(this WrapMode rm)
                 WrapMode.PingPong => HsmWrapMode.PingPong,
                 WrapMode.Default => HsmWrapMode.Default,
                 WrapMode.ClampForever => HsmWrapMode.Once,
-                _ => throw new System.ArgumentOutOfRangeException(nameof(rm), $"Unexpected WrapMode value: {rm}")
+                _ => throw new System.ArgumentOutOfRangeException(nameof(rm), $"Unexpected WrapMode value: {rm}"),
             };
         }
 
@@ -41,7 +41,7 @@ public static WrapMode ToUnityWrapMode(this HsmWrapMode rm)
                 HsmWrapMode.Loop => WrapMode.Loop,
                 HsmWrapMode.PingPong => WrapMode.PingPong,
                 HsmWrapMode.Default => WrapMode.Default,
-                _ => throw new System.ArgumentOutOfRangeException(nameof(rm), $"Unexpected HsmWrapMode value: {rm}")
+                _ => throw new System.ArgumentOutOfRangeException(nameof(rm), $"Unexpected HsmWrapMode value: {rm}"),
             };
         }
     }

HintServiceMeow/Core/Models/HintCollection.cs

@@ -127,6 +127,11 @@ public AbstractHint[] GetHints(string assemblyName, Func<AbstractHint, bool> pre
             }
         }
 
+        /// <summary>
+        /// Adds a hint to the collection under the specified assembly group.
+        /// </summary>
+        /// <param name="assemblyName">The name of the assembly group to add the hint to.</param>
+        /// <param name="hint">The hint to add.</param>
         internal void AddHint(string assemblyName, AbstractHint hint)
         {
             lock (collectionLock)
@@ -143,6 +148,13 @@ internal void AddHint(string assemblyName, AbstractHint hint)
             OnCollectionChanged(new NotifyCollectionChangedEventArgs(NotifyCollectionChangedAction.Add, hint));
         }
 
+        /// <summary>
+        /// Removes the specified hint from the collection.
+        /// If <paramref name="assemblyName"/> is null, the hint is removed from all groups.
+        /// </summary>
+        /// <param name="assemblyName">The assembly group to search in, or null to search all groups.</param>
+        /// <param name="hint">The hint to remove.</param>
+        /// <returns>true if the hint was found and removed; otherwise false.</returns>
         internal bool RemoveHint(string? assemblyName, AbstractHint hint)
         {
             bool success = false;
@@ -203,6 +215,13 @@ internal bool RemoveHint(string? assemblyName, AbstractHint hint)
             return success;
         }
 
+        /// <summary>
+        /// Removes all hints satisfying the predicate from the collection.
+        /// If <paramref name="assemblyName"/> is null, hints are removed from all groups.
+        /// </summary>
+        /// <param name="assemblyName">The assembly group to search in, or null to search all groups.</param>
+        /// <param name="predicate">A function that returns true for hints to remove.</param>
+        /// <returns>A list of hints that were removed.</returns>
         internal List<AbstractHint> RemoveHint(string? assemblyName, Func<AbstractHint, bool> predicate)
         {
             List<AbstractHint> updatedHints = [];
@@ -277,6 +296,10 @@ internal List<AbstractHint> RemoveHint(string? assemblyName, Func<AbstractHint,
             return updatedHints;
         }
 
+        /// <summary>
+        /// Clears all hints from the specified assembly group, or from all groups if null.
+        /// </summary>
+        /// <param name="assemblyName">The assembly group to clear, or null to clear all groups.</param>
         internal void ClearHints(string? assemblyName)
         {
             lock (collectionLock)

HintServiceMeow/Core/Models/ParameterCollection.cs

@@ -10,7 +10,9 @@ public class ParameterCollection : IEnumerable<Tuple<string, IParameter>>
         private readonly object collectionLock = new object();
         private readonly List<Tuple<string, IParameter>> list = new(4);
 
-        public ParameterCollection() { }
+        public ParameterCollection()
+        {
+        }
 
         public ParameterCollection(ParameterCollection other)
         {

HintServiceMeow/Core/Models/Parser/Style/LineStyle.cs

@@ -84,5 +84,18 @@ public override bool Equals(object? obj)
                 && MarginRight == other.MarginRight
                 && MaxWidth == other.MaxWidth;
         }
+
+        /// <inheritdoc/>
+        public override int GetHashCode()
+        {
+            int hash = 17;
+            hash = (hash * 31) + Alignment.GetHashCode();
+            hash = (hash * 31) + LineHeight.GetHashCode();
+            hash = (hash * 31) + Indent.GetHashCode();
+            hash = (hash * 31) + MarginLeft.GetHashCode();
+            hash = (hash * 31) + MarginRight.GetHashCode();
+            hash = (hash * 31) + MaxWidth.GetHashCode();
+            return hash;
+        }
     }
 }

HintServiceMeow/Core/Models/Parser/Style/TextSegmentStyle.cs

@@ -313,5 +313,20 @@ public override bool Equals(object? obj)
                 && Font == other.Font
                 && FontWeight == other.FontWeight;
         }
+
+        /// <inheritdoc/>
+        public override int GetHashCode()
+        {
+            int hash = 17;
+            hash = (hash * 31) + FontSize.GetHashCode();
+            hash = (hash * 31) + Color.GetHashCode();
+            hash = (hash * 31) + Alpha.GetHashCode();
+            hash = (hash * 31) + Bold.GetHashCode();
+            hash = (hash * 31) + Italic.GetHashCode();
+            hash = (hash * 31) + Underline.GetHashCode();
+            hash = (hash * 31) + Strikethrough.GetHashCode();
+            hash = (hash * 31) + Superscript.GetHashCode();
+            return hash;
+        }
     }
 }

HintServiceMeow/Core/Models/Parser/Token.cs

@@ -104,7 +104,7 @@ public override string ToString()
                 RichTextTokenType.CloseTag => $"Close(</{TagName}>)",
                 RichTextTokenType.SelfCloseTag => $"SelfClose(<{TagName}>)",
                 RichTextTokenType.LineBreak => "Newline",
-                _ => "Unknown"
+                _ => "Unknown",
             };
         }
     }