Skip to content

feat: deep-link the logs link to the batch-filtered activity log on batch PRs#600

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/JulianMaurin/julian/mrgfy-7878-browser-extension-batch-row-queue-link-deep-links-to-the/deep-link-logs-link-batch-filtered-activity-log--5c6a7201
Jul 16, 2026
Merged

feat: deep-link the logs link to the batch-filtered activity log on batch PRs#600
mergify[bot] merged 1 commit into
mainfrom
devs/JulianMaurin/julian/mrgfy-7878-browser-extension-batch-row-queue-link-deep-links-to-the/deep-link-logs-link-batch-filtered-activity-log--5c6a7201

Conversation

@JulianMaurin

@JulianMaurin JulianMaurin commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Batch PRs get their logs link back, pointing at the activity log with the
batch_pull filter (the batch's own lifecycle events) instead of the per-PR
event log. The link stays on closed batch PRs — the batch's event history is
the post-mortem trail. preset=Past1month widens the activity log's default
1-hour window, which would render empty for any batch older than an hour;
same convention as the dashboard's own queue → activity-log deep link.

MRGFY-7878

Test plan:

  • npx jest (279 passing) — open batch PR (queue=batch_pr, logs=batch_pull),
    closed batch PR (logs only), non-batch PRs keep the per-PR event-log link.
  • npx biome check — clean.

Depends-On: Mergifyio/monorepo#36623
Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01QyefSTmdtUKXCSbYRJvSQu

@JulianMaurin

JulianMaurin commented Jul 11, 2026

Copy link
Copy Markdown
Contributor Author

This pull request is part of a Mergify stack:

# Pull Request Link
1 feat: deep-link the logs link to the batch-filtered activity log on batch PRs #600 👈
2 feat: point the per-PR logs link directly at the activity log #601

@mergify
mergify Bot had a problem deploying to Mergify Merge Protections July 11, 2026 03:10 Failure
@mergify

mergify Bot commented Jul 11, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 7 merge protections satisfied — ready to merge.

Show 7 satisfied protections

🟢 ⛓️ Depends-On Requirements

Requirement based on the presence of Depends-On in the body of the pull request

  • depends-on = Mergifyio/monorepo#36623 [⛓️ Mergifyio/monorepo#36623]

🟢 🤖 Continuous Integration

  • all of:
    • check-success=ci-gate

🟢 👀 Review Requirements

  • any of:
    • #approved-reviews-by>=2
    • author = dependabot[bot]

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|internal|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?!?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@mergify
mergify Bot requested a review from a team July 11, 2026 03:12
Base automatically changed from devs/JulianMaurin/julian/mrgfy-7878-browser-extension-batch-row-queue-link-deep-links-to-the/restrict-queue-logs-links-merge-queue-batch-prs--23862d88 to main July 13, 2026 09:34
@mergify
mergify Bot force-pushed the devs/JulianMaurin/julian/mrgfy-7878-browser-extension-batch-row-queue-link-deep-links-to-the/deep-link-logs-link-batch-filtered-activity-log--5c6a7201 branch from 70f235e to 557287c Compare July 13, 2026 09:34
@mergify
mergify Bot had a problem deploying to Mergify Merge Protections July 13, 2026 09:34 Failure
…atch PRs

Batch PRs get their logs link back, pointing at the activity log with the
batch_pull filter (the batch's own lifecycle events) instead of the per-PR
event log. The link stays on closed batch PRs — the batch's event history is
the post-mortem trail. preset=Past1month widens the activity log's default
1-hour window, which would render empty for any batch older than an hour;
same convention as the dashboard's own queue → activity-log deep link.

MRGFY-7878

Test plan:
- npx jest (279 passing) — open batch PR (queue=batch_pr, logs=batch_pull),
  closed batch PR (logs only), non-batch PRs keep the per-PR event-log link.
- npx biome check — clean.

Depends-On: Mergifyio/monorepo#36623
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QyefSTmdtUKXCSbYRJvSQu
Change-Id: I5c6a720156143892c507ecfc3921f14c400a5b8b
@JulianMaurin
JulianMaurin force-pushed the devs/JulianMaurin/julian/mrgfy-7878-browser-extension-batch-row-queue-link-deep-links-to-the/deep-link-logs-link-batch-filtered-activity-log--5c6a7201 branch from 557287c to b2c998c Compare July 14, 2026 10:05
Copilot AI review requested due to automatic review settings July 14, 2026 10:05
@JulianMaurin

Copy link
Copy Markdown
Contributor Author

Revision history

# Type Changes Reason Date
1 initial 557287c 2026-07-14 10:05 UTC
2 rebase 557287c → b2c998c (rebase only) 2026-07-14 10:05 UTC

@mergify
mergify Bot deployed to Mergify Merge Protections July 14, 2026 10:05 Active

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restores a “logs” link on merge-queue batch PRs, changing it to deep-link to the dashboard activity log filtered to the batch’s lifecycle events (batch_pull) and keeping that link available after the batch PR is closed for post-mortem inspection.

Changes:

  • Update batch-aware link rendering so batch PRs use an activity-log deep link instead of omitting “logs”.
  • Add getBatchActivityLogLink() to generate the activity-log URL with batch_pull and preset=Past1month.
  • Update Jest coverage for open/closed batch PR link behavior and ensure non-batch PRs still use the per-PR event log link.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
src/queue.js Adds a batch activity-log deep link and uses it for the “logs” link in batch contexts.
src/tests/queue.test.js Updates/expands tests for batch vs non-batch “queue/logs” link targets.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/queue.js
Comment thread src/__tests__/queue.test.js
@JulianMaurin
JulianMaurin marked this pull request as ready for review July 15, 2026 14:05
@mergify
mergify Bot requested a review from a team July 15, 2026 14:47
@mergify

mergify Bot commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 2 minutes 12 seconds in the queue, including 1 minute 49 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Jul 16, 2026
@mergify
mergify Bot merged commit 6a198f5 into main Jul 16, 2026
9 of 12 checks passed
@mergify
mergify Bot deleted the devs/JulianMaurin/julian/mrgfy-7878-browser-extension-batch-row-queue-link-deep-links-to-the/deep-link-logs-link-batch-filtered-activity-log--5c6a7201 branch July 16, 2026 09:51
@mergify mergify Bot removed the queued label Jul 16, 2026
mergify Bot pushed a commit that referenced this pull request Jul 16, 2026
The logs link on non-batch PRs targeted the retired /event-logs URL, riding
the dashboard's redirect + param-translation shim (pullRequestNumber →
pull_request) and landing on the activity log's default 1-hour window —
empty for any PR queued earlier. Target /activity-log directly with
pull_request and preset=Past1month, through a URL builder shared with the
batch link. getEventLogLink() becomes getPullRequestActivityLogLink(),
named after its destination. The "logs" label is unchanged.

MRGFY-7878

Test plan:
- npx jest (279 passing) — non-batch PRs assert the direct activity-log URL
  with pull_request and preset; batch link unchanged.
- npx biome check — clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01QyefSTmdtUKXCSbYRJvSQu

Depends-On: #600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants