feat: deep-link the logs link to the batch-filtered activity log on batch PRs#600
Conversation
|
This pull request is part of a Mergify stack:
|
Merge Protections🟢 All 7 merge protections satisfied — ready to merge. Show 7 satisfied protections🟢 ⛓️ Depends-On RequirementsRequirement based on the presence of
🟢 🤖 Continuous Integration
🟢 👀 Review Requirements
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
70f235e to
557287c
Compare
…atch PRs Batch PRs get their logs link back, pointing at the activity log with the batch_pull filter (the batch's own lifecycle events) instead of the per-PR event log. The link stays on closed batch PRs — the batch's event history is the post-mortem trail. preset=Past1month widens the activity log's default 1-hour window, which would render empty for any batch older than an hour; same convention as the dashboard's own queue → activity-log deep link. MRGFY-7878 Test plan: - npx jest (279 passing) — open batch PR (queue=batch_pr, logs=batch_pull), closed batch PR (logs only), non-batch PRs keep the per-PR event-log link. - npx biome check — clean. Depends-On: Mergifyio/monorepo#36623 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QyefSTmdtUKXCSbYRJvSQu Change-Id: I5c6a720156143892c507ecfc3921f14c400a5b8b
557287c to
b2c998c
Compare
Revision history
|
There was a problem hiding this comment.
Pull request overview
This PR restores a “logs” link on merge-queue batch PRs, changing it to deep-link to the dashboard activity log filtered to the batch’s lifecycle events (batch_pull) and keeping that link available after the batch PR is closed for post-mortem inspection.
Changes:
- Update batch-aware link rendering so batch PRs use an activity-log deep link instead of omitting “logs”.
- Add
getBatchActivityLogLink()to generate theactivity-logURL withbatch_pullandpreset=Past1month. - Update Jest coverage for open/closed batch PR link behavior and ensure non-batch PRs still use the per-PR event log link.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/queue.js | Adds a batch activity-log deep link and uses it for the “logs” link in batch contexts. |
| src/tests/queue.test.js | Updates/expands tests for batch vs non-batch “queue/logs” link targets. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Merge Queue Status
This pull request spent 2 minutes 12 seconds in the queue, including 1 minute 49 seconds running CI. Required conditions to merge
|
The logs link on non-batch PRs targeted the retired /event-logs URL, riding the dashboard's redirect + param-translation shim (pullRequestNumber → pull_request) and landing on the activity log's default 1-hour window — empty for any PR queued earlier. Target /activity-log directly with pull_request and preset=Past1month, through a URL builder shared with the batch link. getEventLogLink() becomes getPullRequestActivityLogLink(), named after its destination. The "logs" label is unchanged. MRGFY-7878 Test plan: - npx jest (279 passing) — non-batch PRs assert the direct activity-log URL with pull_request and preset; batch link unchanged. - npx biome check — clean. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01QyefSTmdtUKXCSbYRJvSQu Depends-On: #600
Batch PRs get their logs link back, pointing at the activity log with the
batch_pull filter (the batch's own lifecycle events) instead of the per-PR
event log. The link stays on closed batch PRs — the batch's event history is
the post-mortem trail. preset=Past1month widens the activity log's default
1-hour window, which would render empty for any batch older than an hour;
same convention as the dashboard's own queue → activity-log deep link.
MRGFY-7878
Test plan:
closed batch PR (logs only), non-batch PRs keep the per-PR event-log link.
Depends-On: Mergifyio/monorepo#36623
Co-Authored-By: Claude Fable 5 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_01QyefSTmdtUKXCSbYRJvSQu