Skip to content

Commit 9dcee6d

Browse files
committed
fix(design): address Phase 3 code review findings
- Remove dead :not(.home-title) guard clauses in src/styles/index.css. The .home-title class was removed from the homepage MDX in Phase 3, so the guards now reference a class that no longer exists in the DOM. - Replace hard-coded hex colors in Search.scss search-highlight marks (#003dff in light, #5468ff in dark) with var(--theme-link). The token is already mode-aware so the dark override is redundant. Change-Id: Ie08c2f698b62a99b80d4ddcb33a635e632b9691d
1 parent 05b5d3a commit 9dcee6d

2 files changed

Lines changed: 5 additions & 6 deletions

File tree

src/components/Search/Search.scss

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
so these styles must NOT be nested under #search-bar. */
77
.modal-content {
88
mark {
9-
color: #003dff;
9+
color: var(--theme-link);
1010
background: transparent;
1111
font-weight: 500;
1212
}
@@ -48,6 +48,5 @@
4848
background: var(--theme-bg-hover) !important;
4949
}
5050

51-
.theme-dark .modal-content mark {
52-
color: #5468ff;
53-
}
51+
/* Dark mode mark color comes from --theme-link's dark-mode remap;
52+
no separate override needed. */

src/styles/index.css

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -880,7 +880,7 @@ pre {
880880
color: var(--theme-text-muted);
881881
}
882882

883-
#main-content h2:not(.content-subtitle):not(.home-title) {
883+
#main-content h2:not(.content-subtitle) {
884884
font-size: 1.5rem;
885885
font-weight: 500;
886886
line-height: 1.3;
@@ -921,7 +921,7 @@ article.content {
921921
position: relative;
922922
}
923923

924-
.content h2:not(.content-subtitle, .home-title):not(.no-counter)::before {
924+
.content h2:not(.content-subtitle):not(.no-counter)::before {
925925
content: counter(h2-section);
926926
font-weight: 500;
927927
margin-right: 0.55rem;

0 commit comments

Comments
 (0)