Skip to content

fix(design): address Phase 3 code review findings #11326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jd wants to merge 1 commit into from
+5 −6
Closed

fix(design): address Phase 3 code review findings #11326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions src/components/Search/Search.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
so these styles must NOT be nested under #search-bar. */
.modal-content {
mark {
color: #003dff;
color: var(--theme-link);
background: transparent;
font-weight: 500;
}
Expand Down Expand Up @@ -48,6 +48,5 @@
background: var(--theme-bg-hover) !important;
}

.theme-dark .modal-content mark {
color: #5468ff;
}
/* Dark mode mark color comes from --theme-link's dark-mode remap;
no separate override needed. */
4 changes: 2 additions & 2 deletions src/styles/index.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -880,7 +880,7 @@ pre {
color: var(--theme-text-muted);
}

#main-content h2:not(.content-subtitle):not(.home-title) {
#main-content h2:not(.content-subtitle) {
font-size: 1.5rem;
font-weight: 500;
line-height: 1.3;
Expand Down Expand Up @@ -921,7 +921,7 @@ article.content {
position: relative;
}

.content h2:not(.content-subtitle, .home-title):not(.no-counter)::before {
.content h2:not(.content-subtitle):not(.no-counter)::before {
content: counter(h2-section);
font-weight: 500;
margin-right: 0.55rem;
Expand Down
Loading