Replies: 1 comment 4 replies
-
|
We're going to release |
Beta Was this translation helpful? Give feedback.
4 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Problem
When a PR is being validated in the merge queue and CI fails due to a flaky test or transient infrastructure issue, the PR is immediately dequeued. This requires manual intervention (
@mergifyio queueor@mergifyio refresh) to get the PR back into the queue, even when the failure is transient and a retry would succeed.This is a common pain point (see #4008, #5044) and becomes especially frustrating in projects where flaky tests or CI infrastructure hiccups are a fact of life.
Current workarounds
autoqueue: true: A dequeued PR can be re-enqueued automatically if it still matchesqueue_conditions, but this requires a fresh CI run from scratch rather than waiting for an in-flight retry to complete.Suggestion
It would be valuable if the merge queue could be made aware of retry attempts before deciding to dequeue a PR. Some possible approaches (open to Mergify's perspective on what fits best):
max_check_retries) that tells the merge queue to retry CI validation N times before dequeuingThe key idea is: don't dequeue until retries have been given a chance to succeed.
Context
We run into this with a mix of flaky tests and transient infrastructure failures. Our current config uses
autoqueue: truewithchecks_timeout: 90 min, but once a check reports failure the PR is dequeued immediately regardless of the timeout.Beta Was this translation helpful? Give feedback.
All reactions