ci(mergify): Re-request devs review until required approvals are met#444
Merged
Conversation
The request-review rule stopped requesting @devs after the first approval (#approved-reviews-by=0), yet the Approval merge protection requires two. A pull request would silently stall after review #1 with no reviewer requested for review #2. Match the monorepo behavior: keep re-requesting @devs while below the two-approval requirement (#approved-reviews-by < 2). When a dev reviews, GitHub drops the team request and Mergify automatically re-adds it until the merge gate is satisfied. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Change-Id: I82bc11b5ba6dc31800e458c81eea8dc8beac0078
Contributor
Merge Protections🟢 All 7 merge protections satisfied — ready to merge. Show 7 satisfied protections🟢 📃 Configuration Change RequirementsMergify configuration change
🟢 Approval
🟢 Continuous Integration
🟢 Enforce conventional commitMake sure that we follow https://www.conventionalcommits.org/en/v1.0.0/
🟢 🔎 Reviews
🟢 📕 PR description
🟢 🚦 Auto-queueWhen all merge protections are satisfied, this pull request will be queued automatically. |
There was a problem hiding this comment.
Pull request overview
Adjusts the Mergify “request review” automation so it keeps (re-)requesting the @devs team review until the repository’s “Approval” merge protection (2 approvals) is satisfied, preventing PRs from stalling after the first approval.
Changes:
- Update the
request reviewrule condition from “0 approvals” to “fewer than 2 approvals” so team review requests are re-added as needed.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
kozlek
approved these changes
Jul 7, 2026
jd
approved these changes
Jul 7, 2026
Contributor
Merge Queue Status
This pull request spent 1 minute 30 seconds in the queue, including 1 minute 3 seconds running CI. Required conditions to merge
|
43 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The request-review rule stopped requesting @devs after the first approval (#approved-reviews-by=0), yet the Approval merge protection requires two. A pull request would silently stall after review #1 with no reviewer requested for review #2.
Match the monorepo behavior: keep re-requesting @devs while below the two-approval requirement (#approved-reviews-by < 2). When a dev reviews, GitHub drops the team request and Mergify automatically re-adds it until the merge gate is satisfied.
Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com