Skip to content

ci(mergify): Re-request devs review until required approvals are met#444

Merged
mergify[bot] merged 1 commit into
mainfrom
devs/remyduthu/rerequest-devs-review/re-req-devs-review-until-required-approvals-met--82bc11b5
Jul 7, 2026
Merged

ci(mergify): Re-request devs review until required approvals are met#444
mergify[bot] merged 1 commit into
mainfrom
devs/remyduthu/rerequest-devs-review/re-req-devs-review-until-required-approvals-met--82bc11b5

Conversation

@remyduthu

Copy link
Copy Markdown
Contributor

The request-review rule stopped requesting @devs after the first approval (#approved-reviews-by=0), yet the Approval merge protection requires two. A pull request would silently stall after review #1 with no reviewer requested for review #2.

Match the monorepo behavior: keep re-requesting @devs while below the two-approval requirement (#approved-reviews-by < 2). When a dev reviews, GitHub drops the team request and Mergify automatically re-adds it until the merge gate is satisfied.

Co-Authored-By: Claude Opus 4.8 (1M context) noreply@anthropic.com

The request-review rule stopped requesting @devs after the first approval (#approved-reviews-by=0), yet the Approval merge protection requires two. A pull request would silently stall after review #1 with no reviewer requested for review #2.

Match the monorepo behavior: keep re-requesting @devs while below the two-approval requirement (#approved-reviews-by < 2). When a dev reviews, GitHub drops the team request and Mergify automatically re-adds it until the merge gate is satisfied.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Change-Id: I82bc11b5ba6dc31800e458c81eea8dc8beac0078
Copilot AI review requested due to automatic review settings July 7, 2026 12:59
@mergify mergify Bot deployed to Mergify Merge Protections July 7, 2026 12:59 Active
@mergify

mergify Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🟢 All 7 merge protections satisfied — ready to merge.

Show 7 satisfied protections

🟢 📃 Configuration Change Requirements

Mergify configuration change

  • check-success = Configuration changed

🟢 Approval

  • #approved-reviews-by >= 2

🟢 Continuous Integration

  • all of:
    • check-success = codespell
    • check-success = test (3.10)
    • check-success = test (3.11)
    • check-success = test (3.12)
    • check-success = test (3.13)
    • check-success = test (3.14)
    • check-success = test (3.8)
    • check-success = test (3.9)

🟢 Enforce conventional commit

Make sure that we follow https://www.conventionalcommits.org/en/v1.0.0/

  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:

🟢 🔎 Reviews

  • #changes-requested-reviews-by = 0
  • #review-requested = 0
  • #review-threads-unresolved = 0

🟢 📕 PR description

  • body ~= (?ms:.{48,})

🟢 🚦 Auto-queue

When all merge protections are satisfied, this pull request will be queued automatically.

@mergify mergify Bot requested a review from a team July 7, 2026 13:00

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adjusts the Mergify “request review” automation so it keeps (re-)requesting the @devs team review until the repository’s “Approval” merge protection (2 approvals) is satisfied, preventing PRs from stalling after the first approval.

Changes:

  • Update the request review rule condition from “0 approvals” to “fewer than 2 approvals” so team review requests are re-added as needed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@remyduthu remyduthu marked this pull request as ready for review July 7, 2026 13:29
@remyduthu remyduthu self-assigned this Jul 7, 2026
@remyduthu remyduthu requested a review from a team July 7, 2026 15:08
@mergify

mergify Bot commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Merge Queue Status

This pull request spent 1 minute 30 seconds in the queue, including 1 minute 3 seconds running CI.

Required conditions to merge

@mergify mergify Bot added the queued label Jul 7, 2026
@mergify mergify Bot merged commit 3cce749 into main Jul 7, 2026
13 checks passed
@mergify mergify Bot deleted the devs/remyduthu/rerequest-devs-review/re-req-devs-review-until-required-approvals-met--82bc11b5 branch July 7, 2026 17:15
@mergify mergify Bot removed the queued label Jul 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants