merge queue: checking main (d9a9ff6) and #444 together#447
Closed
mergify[bot] wants to merge 2 commits into
Closed
merge queue: checking main (d9a9ff6) and #444 together#447mergify[bot] wants to merge 2 commits into
mergify[bot] wants to merge 2 commits into
Conversation
The request-review rule stopped requesting @devs after the first approval (#approved-reviews-by=0), yet the Approval merge protection requires two. A pull request would silently stall after review #1 with no reviewer requested for review #2. Match the monorepo behavior: keep re-requesting @devs while below the two-approval requirement (#approved-reviews-by < 2). When a dev reviews, GitHub drops the team request and Mergify automatically re-adds it until the merge gate is satisfied. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Change-Id: I82bc11b5ba6dc31800e458c81eea8dc8beac0078
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎉 This pull request has been checked successfully and will be merged soon. 🎉
Branch main (d9a9ff6) and #444 are queued together for merge.
This pull request has been created by Mergify to check the mergeability of #444.
You don't need to do anything. Mergify will close this pull request automatically when it is complete.
Required conditions of queue rule
defaultfor merge:github-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Approval]:#approved-reviews-by >= 2Continuous Integration]:check-success = codespellcheck-success = test (3.10)check-success = test (3.11)check-success = test (3.12)check-success = test (3.13)check-success = test (3.14)check-success = test (3.8)check-success = test (3.9)Enforce conventional commit]:title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0Required conditions to stay in the queue:
base = maingithub-review-approved[🛡 GitHub repository ruleset ruleRequire pull request for default branch]Approval]:#approved-reviews-by >= 2Continuous Integration]:check-success = codespellcheck-success = test (3.10)check-success = test (3.11)check-success = test (3.12)check-success = test (3.13)check-success = test (3.14)check-success = test (3.8)check-success = test (3.9)Enforce conventional commit]:title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert|ui)(?:\(.+\))?:📕 PR description]:body ~= (?ms:.{48,})🔎 Reviews]:#changes-requested-reviews-by = 0#review-requested = 0#review-threads-unresolved = 0