GNSS bundle - Elevations, transformations, providers#727
Open
alex-cit wants to merge 13 commits into
Open
Conversation
alex-cit
force-pushed
the
iss_701-describing-providers
branch
from
e69ff61 to
562d0aa
Compare
Withalion
reviewed
Mar 3, 2026
Contributor
Author
|
Thanks @Withalion for the review! I tried to fix most of them. Could you please go over the variables descriptions if it's correct now? Thank you! |
Withalion
approved these changes
Mar 5, 2026
Withalion
left a comment
Withalion
left a comment
There was a problem hiding this comment.
The variables description looks alright now!
Withalion
reviewed
May 26, 2026
alex-cit
force-pushed
the
iss_701-describing-providers
branch
from
b63c5c4 to
4a4e739
Compare
Contributor
Author
|
rebased and:
|
Withalion
reviewed
Jun 15, 2026
| ## Internal provider (no external device) | ||
|
|
||
| ### Android | ||
| On Android, the [internal (fused)](../../field/mobile-app-ui/#gps-settings) GPS provider is used by default. It reports ellipsoidal heights that <MainPlatformName /> transforms to **orthometric heights using the EGM96 geoid model** by default and displays them in the [GPS info panel](../../field/mobile-app-ui/#current-position-and-gps-info). |
There was a problem hiding this comment.
While technical correct wouldn't the wording here be better to switch it up?
It reports ellipsoidal heights that transforms to orthometric heights using the EGM96 geoid model by default and displays them in the GPS info panel.
"It reports orthometric heights transformed from ellipsoid heights..."
|
|
||
|  | ||
|
|
||
| To make sure that <MainPlatformName /> uses the correct operation, make sure that the datum transformation you want to used is defined in the **Transformations** tab in **Project Properties**. |
There was a problem hiding this comment.
make sure that the datum transformation you want to used is defined in the
missing word?
| - for internal GPS, returns "internal" | ||
| - for external GPS, returns "external" | ||
| - for internal GPS, returns `internal` | ||
| - for [external GPS](../../field/external_gps/), returns `external` |
There was a problem hiding this comment.
If this doc is also including the changes from network provider feature, then this either returns external_ip or external_bt.
| - for internal GPS, returns "<NoSpellcheck id="devicegps" />" | ||
| - for external GPS, returns the MAC address | ||
| - for internal GPS, returns `devicegps`, `android_fused` or `android_gps` | ||
| - for [external GPS](../../field/external_gps/), returns the MAC address |
There was a problem hiding this comment.
continuing from the comment above. This should return MAC address for Bluetooth devices and IP address with port for network devices
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #701