Skip to content

Commit 7c5e1cc

Browse files
authored
Add "tables to include" option + version bump to 2.3.0 + CI fixes (#254)
1 parent bc2b4f0 commit 7c5e1cc

19 files changed

Lines changed: 525 additions & 169 deletions

.github/workflows/python_packages.yml

Lines changed: 5 additions & 49 deletions
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,6 @@ jobs:
1111
CIBW_MANYLINUX_X86_64_IMAGE: manylinux_2_28
1212
CIBW_ARCHS: x86_64
1313
CIBW_BEFORE_ALL_LINUX: dnf makecache && dnf install --assumeyes sqlite-devel
14-
CIBW_BEFORE_BUILD: pip install setuptools scikit-build wheel cmake
1514
CIBW_TEST_COMMAND: python -c "import pygeodiff; pygeodiff.GeoDiff().version()"
1615

1716
steps:
@@ -36,7 +35,6 @@ jobs:
3635
env:
3736
CIBW_BUILD: "*musllinux*"
3837
CIBW_BEFORE_ALL_LINUX: apk add sqlite-dev
39-
CIBW_BEFORE_BUILD: pip install setuptools scikit-build wheel cmake
4038
CIBW_TEST_COMMAND: python -c "import pygeodiff; pygeodiff.GeoDiff().version()"
4139

4240
steps:
@@ -59,11 +57,12 @@ jobs:
5957
name: Build wheels on Windows
6058
runs-on: windows-2025
6159
env:
62-
CMAKE_GENERATOR: "Visual Studio 17 2022"
60+
CMAKE_GENERATOR: "Visual Studio 18 2026"
6361
SQLite3_ROOT: "C:/vcpkg/installed/x64-windows"
6462
CIBW_SKIP: "*-win32"
6563
CIBW_TEST_COMMAND: python -c "import pygeodiff; pygeodiff.GeoDiff().version()"
6664
CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: "delvewheel repair --add-path C:/vcpkg/installed/x64-windows/bin --no-mangle-all -v -w {dest_dir} {wheel}"
65+
MSBUILDDISABLENODEREUSE: "1"
6766

6867
steps:
6968
- uses: actions/checkout@v3
@@ -77,7 +76,7 @@ jobs:
7776
run: |
7877
C:/vcpkg/vcpkg install sqlite3[rtree,fts3,json1] --triplet x64-windows
7978
C:/vcpkg/vcpkg integrate install
80-
pip install setuptools scikit-build wheel cmake delvewheel
79+
pip install delvewheel
8180
dir "C:/vcpkg/installed/x64-windows/bin"
8281
8382
- name: Build wheels
@@ -88,41 +87,6 @@ jobs:
8887
path: ./wheelhouse/*.whl
8988
name: dist-windows
9089

91-
build_windows_32_wheels:
92-
name: Build 32bit wheels on Windows
93-
runs-on: windows-2025
94-
env:
95-
CMAKE_GENERATOR: "Visual Studio 17 2022"
96-
CMAKE_GENERATOR_PLATFORM: "Win32"
97-
SQLite3_ROOT: "C:/vcpkg/installed/x86-windows"
98-
CIBW_SKIP: pp* *-win_amd64
99-
CIBW_TEST_COMMAND: python -c "import pygeodiff; pygeodiff.GeoDiff().version()"
100-
CIBW_REPAIR_WHEEL_COMMAND_WINDOWS: "delvewheel repair --add-path C:/vcpkg/installed/x86-windows/bin --no-mangle-all -v -w {dest_dir} {wheel}"
101-
102-
steps:
103-
- uses: actions/checkout@v3
104-
105-
- uses: actions/setup-python@v3
106-
name: Install Python
107-
with:
108-
python-version: '3.9'
109-
architecture: x86
110-
111-
- name: Install Deps
112-
run: |
113-
C:/vcpkg/vcpkg install sqlite3[rtree,fts3,json1] --triplet x86-windows
114-
C:/vcpkg/vcpkg integrate install
115-
pip install setuptools scikit-build wheel cmake delvewheel
116-
dir "C:/vcpkg/installed/x86-windows/bin"
117-
118-
- name: Build wheels
119-
uses: pypa/cibuildwheel@v3.3.1
120-
121-
- uses: actions/upload-artifact@v4
122-
with:
123-
path: ./wheelhouse/*.whl
124-
name: dist-windows_32
125-
12690
build_macos_arm64_wheels:
12791
name: Build wheels on macos-15 (arm64)
12892
runs-on: macos-15
@@ -146,10 +110,6 @@ jobs:
146110
with:
147111
python-version: '3.9'
148112

149-
- name: Install Deps
150-
run: |
151-
pip install setuptools scikit-build wheel cmake
152-
153113
- name: Build wheels
154114
uses: pypa/cibuildwheel@v3.3.1
155115

@@ -181,10 +141,6 @@ jobs:
181141
with:
182142
python-version: '3.9'
183143

184-
- name: Install Deps
185-
run: |
186-
pip install setuptools scikit-build wheel cmake
187-
188144
- name: Build wheels
189145
uses: pypa/cibuildwheel@v3.3.1
190146

@@ -207,10 +163,10 @@ jobs:
207163
- name: Install deps
208164
run: |
209165
pip install --upgrade pip
210-
pip install setuptools twine scikit-build wheel cmake
166+
pip install build twine
211167
212168
- name: Build sdist
213-
run: python setup.py sdist
169+
run: python -m build --sdist
214170

215171
- uses: actions/upload-artifact@v4
216172
with:

.github/workflows/win_tests.yml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,14 @@ jobs:
1111
runs-on: windows-2025
1212
steps:
1313
- name: Checkout Geodiff
14-
uses: actions/checkout@v3
14+
uses: actions/checkout@v6
1515

1616
- name: install deps
1717
run: |
1818
C:/vcpkg/vcpkg install sqlite3[rtree,fts3,json1] --triplet x64-windows
1919
C:/vcpkg/vcpkg integrate install
2020
dir "C:/vcpkg/installed/x64-windows/bin"
2121
22-
- name: set compiler environment
23-
shell: cmd
24-
run: |
25-
CALL "C:\Program Files\Microsoft Visual Studio\2022\Enterprise\Common7\Tools\VsDevCmd.bat" -arch=x86
26-
2722
- name: build geodiff
2823
shell: pwsh
2924
run: |
@@ -37,7 +32,7 @@ jobs:
3732
cd $env:GITHUB_WORKSPACE
3833
mkdir build
3934
cd build
40-
exec { cmake -G "Visual Studio 17 2022" -DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake -DENABLE_TESTS=ON -DWITH_POSTGRESQL=FALSE ../geodiff }
35+
exec { cmake -G "Visual Studio 18 2026" -DCMAKE_TOOLCHAIN_FILE=C:/vcpkg/scripts/buildsystems/vcpkg.cmake -DENABLE_TESTS=ON -DWITH_POSTGRESQL=FALSE ../geodiff }
4136
exec { cmake --build . --config Debug }
4237
4338
- name: Run tests

MANIFEST.in

Lines changed: 0 additions & 11 deletions
This file was deleted.

geodiff/CMakeLists.txt

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
# GEODIFF (MIT License)
22
# Copyright (C) 2019 Peter Petrik
33

4-
CMAKE_MINIMUM_REQUIRED(VERSION 3.10)
4+
CMAKE_MINIMUM_REQUIRED(VERSION 3.15)
55
PROJECT(geodiffproject)
66
SET(CMAKE_CXX_VISIBILITY_PRESET hidden)
77
SET(CMAKE_VISIBILITY_INLINES_HIDDEN 1)
@@ -26,7 +26,11 @@ ENDIF()
2626

2727
IF(SKBUILD)
2828
MESSAGE(STATUS "The geodiff is built using scikit-build for pygeodiff Python package")
29-
FIND_PACKAGE(PythonExtensions REQUIRED)
29+
# scikit-build-core provides the project version as SKBUILD_PROJECT_VERSION;
30+
# allow an explicit -DPYGEODIFFVERSION override for standalone invocations.
31+
IF(NOT PYGEODIFFVERSION)
32+
SET(PYGEODIFFVERSION "${SKBUILD_PROJECT_VERSION}")
33+
ENDIF()
3034
SET(GEODIFF_NAME "pygeodiff-${PYGEODIFFVERSION}-python${GEODIFF_NAME_SUFFIX}")
3135
IF (CMAKE_GENERATOR_PLATFORM STREQUAL "Win32")
3236
SET(GEODIFF_NAME "${GEODIFF_NAME}-win32")

0 commit comments

Comments
 (0)