scroll bar to all list WIP

Author: kaustuvpokharel

app/qml/components/MMListDelegate.qml

@@ -24,6 +24,7 @@ Item {
   property string text
   property string secondaryText
 
+  readonly property int scrollSpace: (ListView.view && ListView.view.scrollSpace) ? ListView.view.scrollSpace : 0
   property alias leftContent: leftContentGroup.children
   property alias rightContent: rightContentGroup.children
 
@@ -40,9 +41,10 @@ Item {
 
   property real verticalSpacing: root.secondaryText ? __style.margin8 : __style.margin20
 
-  implicitWidth: ListView?.view?.width ?? 0 // in case ListView is injected as attached property (usually it is)
+  implicitWidth: ListView?.view?.width ?? 0  // in case ListView is injected as attached property (usually it is)
   implicitHeight: contentLayout.implicitHeight
   height: visible ? implicitHeight : 0.1 // hide invisible items, for some reason setting 0 does not work ¯\_(ツ)_/¯
+  width: implicitWidth - root.scrollSpace
 
   MouseArea {
     anchors.fill: contentLayout

app/qml/components/MMListView.qml

@@ -8,13 +8,35 @@
  ***************************************************************************/
 
 import QtQuick
+import QtQuick.Controls
 
 //
 // Hot-fix for hotfix https://github.com/MerginMaps/mobile/issues/3417
 // Seems like there is some issue with cache in ListView
 //
 
 ListView {
+  id: root
 
   cacheBuffer: 0
+  readonly property bool isMobile: (Qt.platform.os === "android" || Qt.platform.os === "ios")
+  property int scrollSpace: !isMobile ? 10 : 0
+
+  ScrollBar.vertical: ScrollBar {
+    id: verticalScrollBar
+
+    policy: ScrollBar.AlwaysOn
+    visible: !isMobile && (root.contentHeight > root.height)
+    opacity: (pressed || root.moving) ? 0.7 : 0.4
+
+    anchors.right: root.right
+
+    implicitHeight: root.height
+
+    contentItem: Rectangle {
+      implicitWidth: 5
+      radius: width / 2
+      color: __style.darkGreenColor
+    }
+  }
 }

app/qml/components/MMScrollView.qml

@@ -20,4 +20,5 @@ ScrollView {
 
   ScrollBar.vertical.policy: ScrollBar.AlwaysOff
   ScrollBar.horizontal.policy: ScrollBar.AlwaysOff
+
 }

app/qml/layers/MMFeaturesListPage.qml

@@ -73,23 +73,6 @@ MMComponents.MMPage {
         onClicked: root.featureClicked( model.FeaturePair )
       }
 
-      ScrollBar.vertical: ScrollBar {
-        id: verticalScrollBar
-
-        readonly property bool isMobile: (Qt.platform.os === "android" || Qt.platform.os === "ios")
-        policy: ScrollBar.AlwaysOn
-        visible: !isMobile
-        opacity: (pressed || listView.moving) ? 0.7 : 0.4
-
-        implicitHeight: listView.height
-
-        contentItem: Rectangle {
-          implicitWidth: 5
-          radius: width / 2
-          color: __style.darkGreenColor
-        }
-      }
-
       footer: MMComponents.MMListSpacer {
         height: __style.margin20 + ( root.hasToolbar ? 0 : __style.safeAreaBottom ) + ( addButton.visible ? addButton.height : 0 )
       }