Skip to content

Commit 4bd3ddc

Browse files
committed
Abort on invalid order param
1 parent d8734fb commit 4bd3ddc

2 files changed

Lines changed: 6 additions & 1 deletion

File tree

server/mergin/tests/test_public_api_v2.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -651,6 +651,11 @@ def test_list_workspace_projects(client):
651651
resp_data = json.loads(response.data)
652652
assert resp_data["projects"][0]["name"] == project_name
653653

654+
# invalid order param
655+
response = client.get(url + f"?page=1&per_page=10&order_params=invalid DESC")
656+
assert response.status_code == 400
657+
assert response.json["detail"] == "Invalid order parameter"
658+
654659
# no permissions to workspace
655660
user2 = add_user("user", "password")
656661
login(client, user2.username, "password")

server/mergin/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ def get_order_param(
5959
attr = None
6060
order_attr = cls.__table__.c.get(col, None)
6161
if not isinstance(order_attr, Column):
62-
return
62+
abort(400, "Invalid order parameter")
6363
# sort by key in JSON field
6464
if attr:
6565
if not json_sort:

0 commit comments

Comments
 (0)