Skip to content

Commit 7e25d37

Browse files
committed
add assertion for update_diff and not diff attribute.
1 parent 6d30574 commit 7e25d37

2 files changed

Lines changed: 4 additions & 3 deletions

File tree

server/mergin/sync/files.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -286,8 +286,6 @@ def to_data_delta(self):
286286
change=self.change,
287287
version=self.version,
288288
)
289-
if self.diffs:
290-
result.diff = None
291289
return result
292290

293291

@@ -332,6 +330,9 @@ def make_object(self, data, **kwargs):
332330

333331
@post_dump
334332
def patch_field(self, data, **kwargs):
333+
assert data.get("change") != PushChangeType.UPDATE_DIFF.value or data.get(
334+
"diff"
335+
), "Diff file must be provided for update_diff change type"
335336
# drop 'diff' key entirely if empty or None as database would expect
336337
if not data.get("diff"):
337338
data.pop("diff", None)

server/mergin/sync/models.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1043,7 +1043,7 @@ def construct_checkpoint(self) -> bool:
10431043
project.storage.geodiff.concat_changes(diffs_paths, self.abs_path)
10441044
except (GeoDiffLibError, GeoDiffLibConflictError):
10451045
logging.error(
1046-
f"Geodiff: Failed to merge diffs for file {self.file_path_id}. Diffs: {diffs_paths}"
1046+
f"Geodiff: Failed to merge diffs for file {self.file_path_id}."
10471047
)
10481048
return False
10491049

0 commit comments

Comments
 (0)