fix: add missing praisonai_platform.db module (fixes #1542) (#1547)

praisonai-triage-agent[bot] · MervinPraison · web-flow · commit 26d166d379d5 · 2026-04-24T11:12:57.000+01:00
* fix: add missing praisonai_platform.db module (fixes #1542) - Create missing db/ directory with __init__.py, base.py, and models.py - Add all required database models: User, Workspace, Agent, Issue, etc. - Implement SQLAlchemy base configuration with init_db, get_session - Fix package imports with lazy loading in __init__.py - Resolves ModuleNotFoundError that prevented tests from running Tests now begin executing instead of failing at import. Co-authored-by: praisonai-triage-agent[bot] <praisonai-triage-agent[bot]@users.noreply.github.com> * fix: address critical P1 runtime issues found by reviewers - Fix User model field mismatch: change username/hashed_password to name/password_hash to match auth_service.py expectations - Fix get_session() signature incompatibility: update deps.py to properly use async generator pattern - Add missing foreign key constraints for user references (assignee_id, created_by_id, author_id, actor_id) - Fix timezone handling: add timezone=True to all DateTime columns to match _utcnow() - Make reset_engine async and properly dispose connections to prevent leaks - Add database_url parameter to get_engine for test flexibility - Remove unused imports (Engine, Boolean) - Fix wildcard import in db/__init__.py using explicit module import for side effects - Add __dir__ method to main __init__.py for better tab completion Fixes all P1 runtime issues identified by Greptile and CodeRabbit reviewers. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-authored-by: Mervin Praison <MervinPraison@users.noreply.github.com> --------- Co-authored-by: praisonai-triage-agent[bot] <272766704+praisonai-triage-agent[bot]@users.noreply.github.com> Co-authored-by: praisonai-triage-agent[bot] <praisonai-triage-agent[bot]@users.noreply.github.com> Co-authored-by: Mervin Praison <MervinPraison@users.noreply.github.com>
diff --git a/src/praisonai-platform/praisonai_platform/__init__.py b/src/praisonai-platform/praisonai_platform/__init__.py
@@ -19,8 +19,21 @@
 
 __version__ = "0.1.0"
 
-from .api.app import create_app
-from .client.platform_client import PlatformClient
+
+def __getattr__(name: str):
+    """Lazy import for platform components."""
+    if name == "create_app":
+        from .api.app import create_app
+        return create_app
+    elif name == "PlatformClient":
+        from .client.platform_client import PlatformClient
+        return PlatformClient
+    raise AttributeError(f"module 'praisonai_platform' has no attribute '{name}'")
+
+
+def __dir__() -> list[str]:
+    return sorted(list(globals().keys()) + ["create_app", "PlatformClient"])
+
 
 __all__ = [
     "__version__",
diff --git a/src/praisonai-platform/praisonai_platform/api/deps.py b/src/praisonai-platform/praisonai_platform/api/deps.py
@@ -16,8 +16,7 @@
 
 async def get_db() -> AsyncGenerator[AsyncSession, None]:
     """Yield an async DB session per request."""
-    factory = get_session()
-    async with factory() as session:
+    async for session in get_session():
         try:
             yield session
             await session.commit()
diff --git a/src/praisonai-platform/praisonai_platform/db/__init__.py b/src/praisonai-platform/praisonai_platform/db/__init__.py
@@ -0,0 +1,12 @@
+"""Database module for praisonai-platform."""
+
+from .base import Base, get_engine, get_session, init_db, reset_engine
+from . import models  # noqa: F401  # ensure ORM classes are registered with Base.metadata
+
+__all__ = [
+    "Base",
+    "get_session", 
+    "init_db",
+    "reset_engine",
+    "get_engine",
+]
diff --git a/src/praisonai-platform/praisonai_platform/db/base.py b/src/praisonai-platform/praisonai_platform/db/base.py
@@ -0,0 +1,84 @@
+"""Database base configuration for praisonai-platform."""
+
+import os
+from typing import AsyncGenerator
+
+from sqlalchemy.ext.asyncio import (
+    AsyncEngine,
+    AsyncSession,
+    async_sessionmaker,
+    create_async_engine,
+)
+from sqlalchemy.orm import DeclarativeBase
+
+
+class Base(DeclarativeBase):
+    """Base class for all database models."""
+    pass
+
+
+# Global engine instance
+_engine: AsyncEngine | None = None
+_session_factory: async_sessionmaker[AsyncSession] | None = None
+
+
+def get_engine(database_url: str | None = None) -> AsyncEngine:
+    """Get (and lazily create) the cached async database engine.
+
+    If ``database_url`` is provided and no engine is cached yet, it overrides
+    the ``DATABASE_URL`` env var / in-memory default. To switch URLs after an
+    engine has already been created, call ``reset_engine()`` first.
+    """
+    global _engine
+    if _engine is None:
+        if database_url is None:
+            # Default to in-memory SQLite for testing
+            database_url = os.environ.get(
+                "DATABASE_URL",
+                "sqlite+aiosqlite:///:memory:",
+            )
+        _engine = create_async_engine(
+            database_url,
+            echo=False,
+            connect_args={"check_same_thread": False} if "sqlite" in database_url else {},
+        )
+    return _engine
+
+
+async def reset_engine() -> None:
+    """Reset the global engine (for testing).
+
+    Disposes the existing async engine (if any) before clearing
+    cached references so connection pools don't leak across tests.
+    """
+    global _engine, _session_factory
+    if _engine is not None:
+        await _engine.dispose()
+    _engine = None
+    _session_factory = None
+
+
+def get_session_factory() -> async_sessionmaker[AsyncSession]:
+    """Get the session factory."""
+    global _session_factory
+    if _session_factory is None:
+        _session_factory = async_sessionmaker(
+            bind=get_engine(),
+            class_=AsyncSession,
+            expire_on_commit=False,
+        )
+    return _session_factory
+
+
+async def get_session() -> AsyncGenerator[AsyncSession, None]:
+    """Get a database session."""
+    factory = get_session_factory()
+    async with factory() as session:
+        yield session
+
+
+async def init_db() -> None:
+    """Initialize the database (create all tables)."""
+    engine = get_engine()
+    async with engine.begin() as conn:
+        await conn.run_sync(Base.metadata.create_all)
diff --git a/src/praisonai-platform/praisonai_platform/db/models.py b/src/praisonai-platform/praisonai_platform/db/models.py
@@ -0,0 +1,218 @@
+"""Database models for praisonai-platform."""
+
+import uuid
+from datetime import datetime, timezone
+from typing import Any, Dict, List, Optional
+
+from sqlalchemy import (
+    DateTime,
+    ForeignKey,
+    Integer,
+    JSON,
+    String,
+    Text,
+    UniqueConstraint,
+)
+from sqlalchemy.orm import Mapped, mapped_column, relationship
+
+from .base import Base
+
+
+def _uuid() -> str:
+    """Generate a new UUID string."""
+    return str(uuid.uuid4())
+
+
+def _utcnow() -> datetime:
+    """Get current UTC datetime."""
+    return datetime.now(timezone.utc)
+
+
+class User(Base):
+    """User model for authentication."""
+    __tablename__ = "users"
+
+    id: Mapped[str] = mapped_column(String, primary_key=True, default=_uuid)
+    name: Mapped[str] = mapped_column(String, unique=True, nullable=False)
+    email: Mapped[str] = mapped_column(String, unique=True, nullable=False)
+    password_hash: Mapped[str] = mapped_column(String, nullable=False)
+    created_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow)
+    updated_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow, onupdate=_utcnow)
+
+    # Relationships
+    memberships: Mapped[List["Member"]] = relationship("Member", back_populates="user")
+
+
+class Workspace(Base):
+    """Workspace model for organizing work."""
+    __tablename__ = "workspaces"
+
+    id: Mapped[str] = mapped_column(String, primary_key=True, default=_uuid)
+    name: Mapped[str] = mapped_column(String, nullable=False)
+    description: Mapped[Optional[str]] = mapped_column(Text, nullable=True)
+    settings: Mapped[Optional[Dict[str, Any]]] = mapped_column(JSON, nullable=True, default=dict)
+    issue_prefix: Mapped[str] = mapped_column(String, default="ISSUE")
+    created_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow)
+    updated_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow, onupdate=_utcnow)
+
+    # Relationships
+    members: Mapped[List["Member"]] = relationship("Member", back_populates="workspace")
+    projects: Mapped[List["Project"]] = relationship("Project", back_populates="workspace")
+    issues: Mapped[List["Issue"]] = relationship("Issue", back_populates="workspace")
+    agents: Mapped[List["Agent"]] = relationship("Agent", back_populates="workspace")
+
+
+class Member(Base):
+    """Workspace membership model."""
+    __tablename__ = "members"
+
+    id: Mapped[str] = mapped_column(String, primary_key=True, default=_uuid)
+    user_id: Mapped[str] = mapped_column(String, ForeignKey("users.id"), nullable=False)
+    workspace_id: Mapped[str] = mapped_column(String, ForeignKey("workspaces.id"), nullable=False)
+    role: Mapped[str] = mapped_column(String, nullable=False, default="member")  # owner, admin, member
+    created_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow)
+    updated_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow, onupdate=_utcnow)
+
+    # Relationships
+    user: Mapped["User"] = relationship("User", back_populates="memberships")
+    workspace: Mapped["Workspace"] = relationship("Workspace", back_populates="members")
+
+    __table_args__ = (
+        UniqueConstraint("user_id", "workspace_id", name="uq_member_user_workspace"),
+    )
+
+
+class Project(Base):
+    """Project model for organizing issues."""
+    __tablename__ = "projects"
+
+    id: Mapped[str] = mapped_column(String, primary_key=True, default=_uuid)
+    workspace_id: Mapped[str] = mapped_column(String, ForeignKey("workspaces.id"), nullable=False)
+    name: Mapped[str] = mapped_column(String, nullable=False)
+    description: Mapped[Optional[str]] = mapped_column(Text, nullable=True)
+    settings: Mapped[Optional[Dict[str, Any]]] = mapped_column(JSON, nullable=True, default=dict)
+    created_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow)
+    updated_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow, onupdate=_utcnow)
+
+    # Relationships
+    workspace: Mapped["Workspace"] = relationship("Workspace", back_populates="projects")
+    issues: Mapped[List["Issue"]] = relationship("Issue", back_populates="project")
+
+
+class Issue(Base):
+    """Issue model for tracking work items."""
+    __tablename__ = "issues"
+
+    id: Mapped[str] = mapped_column(String, primary_key=True, default=_uuid)
+    workspace_id: Mapped[str] = mapped_column(String, ForeignKey("workspaces.id"), nullable=False)
+    project_id: Mapped[Optional[str]] = mapped_column(String, ForeignKey("projects.id"), nullable=True)
+    title: Mapped[str] = mapped_column(String, nullable=False)
+    description: Mapped[Optional[str]] = mapped_column(Text, nullable=True)
+    status: Mapped[str] = mapped_column(String, nullable=False, default="backlog")
+    priority: Mapped[str] = mapped_column(String, nullable=False, default="medium")
+    assignee_id: Mapped[Optional[str]] = mapped_column(String, ForeignKey("users.id"), nullable=True)
+    created_by_id: Mapped[Optional[str]] = mapped_column(String, ForeignKey("users.id"), nullable=True)
+    issue_number: Mapped[Optional[int]] = mapped_column(Integer, nullable=True)
+    created_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow)
+    updated_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow, onupdate=_utcnow)
+
+    # Relationships
+    workspace: Mapped["Workspace"] = relationship("Workspace", back_populates="issues")
+    project: Mapped[Optional["Project"]] = relationship("Project", back_populates="issues")
+    comments: Mapped[List["Comment"]] = relationship("Comment", back_populates="issue")
+    labels: Mapped[List["IssueLabelLink"]] = relationship("IssueLabelLink", back_populates="issue")
+
+
+class Comment(Base):
+    """Comment model for issue discussions."""
+    __tablename__ = "comments"
+
+    id: Mapped[str] = mapped_column(String, primary_key=True, default=_uuid)
+    issue_id: Mapped[str] = mapped_column(String, ForeignKey("issues.id"), nullable=False)
+    author_id: Mapped[Optional[str]] = mapped_column(String, ForeignKey("users.id"), nullable=True)
+    content: Mapped[str] = mapped_column(Text, nullable=False)
+    created_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow)
+    updated_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow, onupdate=_utcnow)
+
+    # Relationships
+    issue: Mapped["Issue"] = relationship("Issue", back_populates="comments")
+
+
+class Agent(Base):
+    """Agent model for AI agents in workspace."""
+    __tablename__ = "agents"
+
+    id: Mapped[str] = mapped_column(String, primary_key=True, default=_uuid)
+    workspace_id: Mapped[str] = mapped_column(String, ForeignKey("workspaces.id"), nullable=False)
+    name: Mapped[str] = mapped_column(String, nullable=False)
+    description: Mapped[Optional[str]] = mapped_column(Text, nullable=True)
+    status: Mapped[str] = mapped_column(String, nullable=False, default="idle")
+    config: Mapped[Optional[Dict[str, Any]]] = mapped_column(JSON, nullable=True, default=dict)
+    created_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow)
+    updated_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow, onupdate=_utcnow)
+
+    # Relationships
+    workspace: Mapped["Workspace"] = relationship("Workspace", back_populates="agents")
+
+
+class IssueLabel(Base):
+    """Label definitions for issues."""
+    __tablename__ = "issue_labels"
+
+    id: Mapped[str] = mapped_column(String, primary_key=True, default=_uuid)
+    workspace_id: Mapped[str] = mapped_column(String, ForeignKey("workspaces.id"), nullable=False)
+    name: Mapped[str] = mapped_column(String, nullable=False)
+    color: Mapped[str] = mapped_column(String, nullable=False, default="#000000")
+    description: Mapped[Optional[str]] = mapped_column(Text, nullable=True)
+    created_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow)
+    updated_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow, onupdate=_utcnow)
+
+    # Relationships
+    issues: Mapped[List["IssueLabelLink"]] = relationship("IssueLabelLink", back_populates="label")
+
+
+class IssueLabelLink(Base):
+    """Many-to-many relationship between issues and labels."""
+    __tablename__ = "issue_label_links"
+
+    id: Mapped[str] = mapped_column(String, primary_key=True, default=_uuid)
+    issue_id: Mapped[str] = mapped_column(String, ForeignKey("issues.id"), nullable=False)
+    label_id: Mapped[str] = mapped_column(String, ForeignKey("issue_labels.id"), nullable=False)
+    created_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow)
+
+    # Relationships
+    issue: Mapped["Issue"] = relationship("Issue", back_populates="labels")
+    label: Mapped["IssueLabel"] = relationship("IssueLabel", back_populates="issues")
+
+    __table_args__ = (
+        UniqueConstraint("issue_id", "label_id", name="uq_issue_label"),
+    )
+
+
+class IssueDependency(Base):
+    """Issue dependency relationships."""
+    __tablename__ = "issue_dependencies"
+
+    id: Mapped[str] = mapped_column(String, primary_key=True, default=_uuid)
+    issue_id: Mapped[str] = mapped_column(String, ForeignKey("issues.id"), nullable=False)
+    depends_on_id: Mapped[str] = mapped_column(String, ForeignKey("issues.id"), nullable=False)
+    dependency_type: Mapped[str] = mapped_column(String, nullable=False)  # blocks, blocked_by, related
+    created_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow)
+
+    __table_args__ = (
+        UniqueConstraint("issue_id", "depends_on_id", "dependency_type", name="uq_issue_dependency"),
+    )
+
+
+class ActivityLog(Base):
+    """Activity log for tracking changes."""
+    __tablename__ = "activity_logs"
+
+    id: Mapped[str] = mapped_column(String, primary_key=True, default=_uuid)
+    workspace_id: Mapped[str] = mapped_column(String, ForeignKey("workspaces.id"), nullable=False)
+    entity_type: Mapped[str] = mapped_column(String, nullable=False)  # issue, project, workspace, etc.
+    entity_id: Mapped[str] = mapped_column(String, nullable=False)
+    action: Mapped[str] = mapped_column(String, nullable=False)  # created, updated, deleted, etc.
+    actor_id: Mapped[Optional[str]] = mapped_column(String, ForeignKey("users.id"), nullable=True)
+    details: Mapped[Optional[Dict[str, Any]]] = mapped_column(JSON, nullable=True, default=dict)
+    created_at: Mapped[datetime] = mapped_column(DateTime(timezone=True), default=_utcnow)
