refactor: streamline test functions in test_scheduler.py

- Removed unnecessary try-except blocks in test functions for cleaner code.
- Optimised the structure of test cases for better readability and maintainability.
- Ensured consistent import statements and improved error handling in test execution.
- Maintained functionality while adhering to the principle of minimal code change.

Author: MervinPraison

src/praisonai/tests/unit/test_scheduler.py

@@ -14,115 +14,91 @@
 
 def test_schedule_parser():
     """Test the schedule parser functionality."""
-    try:
-        from praisonai.scheduler import ScheduleParser
-        
-        # Test various schedule expressions
-        test_cases = [
-            ("daily", 86400),
-            ("hourly", 3600),
-            ("*/30m", 1800),
-            ("*/6h", 21600),
-            ("60", 60),
-            ("3600", 3600)
-        ]
-        
-        print("Testing ScheduleParser...")
-        for expr, expected in test_cases:
-            result = ScheduleParser.parse(expr)
-            assert result == expected, f"Expected {expected}, got {result} for '{expr}'"
-            print(f"  ✓ '{expr}' -> {result} seconds")
-        
-        print("ScheduleParser tests passed!")
-        return True
-        
-    except Exception as e:
-        print(f"ScheduleParser test failed: {e}")
-        return False
+    from praisonai.scheduler import ScheduleParser
+    
+    # Test various schedule expressions
+    test_cases = [
+        ("daily", 86400),
+        ("hourly", 3600),
+        ("*/30m", 1800),
+        ("*/6h", 21600),
+        ("60", 60),
+        ("3600", 3600)
+    ]
+    
+    print("Testing ScheduleParser...")
+    for expr, expected in test_cases:
+        result = ScheduleParser.parse(expr)
+        assert result == expected, f"Expected {expected}, got {result} for '{expr}'"
+        print(f"  ✓ '{expr}' -> {result} seconds")
+    
+    print("ScheduleParser tests passed!")
 
 def test_scheduler_creation():
     """Test scheduler creation and basic functionality."""
-    try:
-        from praisonai.scheduler import create_scheduler, DeploymentScheduler
-        
-        print("Testing scheduler creation...")
-        
-        # Test default scheduler
-        scheduler = create_scheduler()
+    from praisonai.scheduler import create_scheduler, DeploymentScheduler
+    
+    print("Testing scheduler creation...")
+    
+    # Test default scheduler
+    scheduler = create_scheduler()
+    assert isinstance(scheduler, DeploymentScheduler)
+    print("  ✓ Default scheduler created")
+    
+    # Test with different providers
+    for provider in ["gcp", "aws", "azure"]:
+        scheduler = create_scheduler(provider=provider)
         assert isinstance(scheduler, DeploymentScheduler)
-        print("  ✓ Default scheduler created")
-        
-        # Test with different providers
-        for provider in ["gcp", "aws", "azure"]:
-            scheduler = create_scheduler(provider=provider)
-            assert isinstance(scheduler, DeploymentScheduler)
-            print(f"  ✓ {provider} scheduler created")
-        
-        print("Scheduler creation tests passed!")
-        return True
-        
-    except Exception as e:
-        print(f"Scheduler creation test failed: {e}")
-        return False
+        print(f"  ✓ {provider} scheduler created")
+    
+    print("Scheduler creation tests passed!")
 
 def test_config_file_parsing():
     """Test configuration file parsing."""
-    try:
-        # Create a temporary config file
-        config_data = {
-            'deployment': {
-                'schedule': 'daily',
-                'provider': 'gcp',
-                'max_retries': 5
-            },
-            'environment': {
-                'TEST_VAR': 'test_value'
-            }
+    # Create a temporary config file
+    config_data = {
+        'deployment': {
+            'schedule': 'daily',
+            'provider': 'gcp',
+            'max_retries': 5
+        },
+        'environment': {
+            'TEST_VAR': 'test_value'
         }
-        
-        with tempfile.NamedTemporaryFile(mode='w', suffix='.yaml', delete=False) as f:
-            yaml.dump(config_data, f)
-            config_file = f.name
-        
-        print("Testing config file parsing...")
-        
-        # Test loading the config
-        with open(config_file, 'r') as f:
-            loaded_config = yaml.safe_load(f)
-        
-        assert loaded_config['deployment']['schedule'] == 'daily'
-        assert loaded_config['deployment']['provider'] == 'gcp'
-        assert loaded_config['deployment']['max_retries'] == 5
-        print("  ✓ Config file parsed correctly")
-        
-        # Clean up
-        os.unlink(config_file)
-        
-        print("Config file parsing tests passed!")
-        return True
-        
-    except Exception as e:
-        print(f"Config file parsing test failed: {e}")
-        return False
+    }
+    
+    with tempfile.NamedTemporaryFile(mode='w', suffix='.yaml', delete=False) as f:
+        yaml.dump(config_data, f)
+        config_file = f.name
+    
+    print("Testing config file parsing...")
+    
+    # Test loading the config
+    with open(config_file, 'r') as f:
+        loaded_config = yaml.safe_load(f)
+    
+    assert loaded_config['deployment']['schedule'] == 'daily'
+    assert loaded_config['deployment']['provider'] == 'gcp'
+    assert loaded_config['deployment']['max_retries'] == 5
+    print("  ✓ Config file parsed correctly")
+    
+    # Clean up
+    os.unlink(config_file)
+    
+    print("Config file parsing tests passed!")
 
 def test_cli_argument_parsing():
     """Test CLI argument parsing for scheduling options."""
-    try:
-        from praisonai.cli import PraisonAI
-        
-        print("Testing CLI argument parsing...")
-        
-        # Test basic CLI instantiation
-        praison = PraisonAI()
-        assert praison is not None
-        print("  ✓ PraisonAI CLI instance created")
-        
-        print("CLI argument parsing tests passed!")
-        return True
-        
-    except Exception as e:
-        print(f"CLI argument parsing test failed: {e}")
-        return False
+    from praisonai.cli import PraisonAI
+    
+    print("Testing CLI argument parsing...")
+    
+    # Test basic CLI instantiation
+    praison = PraisonAI()
+    assert praison is not None
+    print("  ✓ PraisonAI CLI instance created")
+    
+    print("CLI argument parsing tests passed!")
 
 def main():
     """Run all tests."""
@@ -141,10 +117,11 @@ def main():
 
     for test in tests:
         print()
-        if test():
+        try:
+            test()
             passed += 1
-        else:
-            print("❌ Test failed")
+        except Exception as e:
+            print(f"❌ Test failed: {e}")
 
     print()
     print("=" * 40)