Skip to content

Commit 5906289

Browse files
refactor: tighten source fallback semantics in rag context
Agent-Logs-Url: https://github.com/MervinPraison/PraisonAI/sessions/fbaed72c-c0f6-4426-8cb4-09c3542f499f Co-authored-by: MervinPraison <454862+MervinPraison@users.noreply.github.com>
1 parent 4c3a910 commit 5906289

1 file changed

Lines changed: 9 additions & 3 deletions

File tree

  • src/praisonai-agents/praisonaiagents/rag

src/praisonai-agents/praisonaiagents/rag/context.py

Lines changed: 9 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -90,7 +90,9 @@ def deduplicate_chunks(
9090
if not isinstance(metadata, dict):
9191
metadata = {}
9292

93-
source = metadata.get("source", "") or _extract_value(result, "source", "")
93+
source = metadata.get("source")
94+
if source is None:
95+
source = _extract_value(result, "source", "")
9496

9597
chunk_id = _chunk_hash(text, source)
9698

@@ -187,8 +189,12 @@ def build_context(
187189
if not isinstance(metadata, dict):
188190
metadata = {}
189191

190-
source = metadata.get("source", "") or _extract_value(result, "source", "")
191-
filename = metadata.get("filename", "") or _extract_value(result, "filename", "")
192+
source = metadata.get("source")
193+
if source is None:
194+
source = _extract_value(result, "source", "")
195+
filename = metadata.get("filename")
196+
if filename is None:
197+
filename = _extract_value(result, "filename", "")
192198
source_label = filename or source or f"Source {i + 1}"
193199
chunk_text = f"[{source_label}]\n{text}"
194200
else:

0 commit comments

Comments
 (0)