fix: resolve critical issues in architectural violations PR

- Fix AgentExecutorInterface import error by aliasing ExecutorInterface
- Fix dead telemetry code by calling _ensure_telemetry_defaults in PraisonAI.__init__
- Fix MCP schedule tools to use proper SDK schedule_tools instead of broken AgentScheduler calls
- Fix type annotations in tool_resolver.py to use Mapping for immutable cache
- Fix misleading deprecation warning in async_agent_scheduler.py

These fixes resolve the 2 P1 critical regressions and 1 P2 issue identified
by multiple reviewers (Greptile, CodeRabbit, Copilot).

Co-authored-by: Mervin Praison <MervinPraison@users.noreply.github.com>

Author: praisonai-triage-agent[bot]

src/praisonai/praisonai/agent_scheduler.py

@@ -13,6 +13,7 @@
 )
 
 from praisonai.scheduler.agent_scheduler import (  # noqa: F401
-    AgentScheduler, PraisonAgentExecutor, AgentExecutorInterface,
-    create_agent_scheduler
-)
+    AgentScheduler, PraisonAgentExecutor, create_agent_scheduler
+)
+# Preserve the legacy public name as an alias of the canonical interface
+from praisonai.scheduler.base import ExecutorInterface as AgentExecutorInterface  # noqa: F401

src/praisonai/praisonai/async_agent_scheduler.py

@@ -7,9 +7,11 @@
 import warnings
 
 warnings.warn(
-    "praisonai.async_agent_scheduler is deprecated; "
-    "use 'from praisonai.scheduler import AsyncAgentScheduler' instead.",
-    DeprecationWarning, stacklevel=2,
+    "praisonai.async_agent_scheduler is pending deprecation; it will be moved to "
+    "praisonai.scheduler.async_agent_scheduler in a future release. Continue "
+    "importing from praisonai.async_agent_scheduler until then.",
+    PendingDeprecationWarning,
+    stacklevel=2,
 )
 
 # TODO: Once AsyncAgentScheduler is moved to scheduler package, import from there

src/praisonai/praisonai/cli/main.py

@@ -248,6 +248,9 @@ def __init__(self, agent_file="agents.yaml", framework="", auto=False, init=Fals
         """
         Initialize the PraisonAI object with default parameters.
         """
+        # Initialize telemetry defaults (moved from lazy __getattr__ hook)
+        from praisonai import _ensure_telemetry_defaults
+        _ensure_telemetry_defaults()
         self.agent_yaml = agent_yaml
         self._interactive_mode = False  # Flag for interactive TUI mode
         # Create config_list with AutoGen compatibility
@@ -331,9 +334,7 @@ def main(self):
         initializes the necessary attributes, and then calls the appropriate methods based on the
         provided arguments.
         """
-        # Set OpenTelemetry SDK to disabled to prevent telemetry collection
-        # Moved from agents_generator.py to CLI entry point per architecture requirements
-        os.environ.setdefault("OTEL_SDK_DISABLED", "true")
+        # Telemetry defaults now handled in PraisonAI.__init__ with Langfuse awareness
 
         # Store the original agent_file from constructor
         original_agent_file = self.agent_file

src/praisonai/praisonai/mcp_server/adapters/cli_tools.py

@@ -344,12 +344,10 @@ def tools_search(query: str) -> str:
     def schedule_list() -> str:
         """List scheduled tasks."""
         try:
-            from praisonai.scheduler import AgentScheduler
-            scheduler = AgentScheduler()
-            tasks = scheduler.list_tasks()
-            return str(tasks)
+            from praisonaiagents.tools.schedule_tools import schedule_list as _schedule_list
+            return _schedule_list()
         except ImportError:
-            return "Error: Scheduler not available"
+            return "Error: Schedule tools not available"
         except Exception as e:
             return f"Error: {e}"
 
@@ -361,25 +359,21 @@ def schedule_add(
     ) -> str:
         """Add a scheduled task."""
         try:
-            from praisonai.scheduler import AgentScheduler
-            scheduler = AgentScheduler()
-            scheduler.add_task(task_name, cron, workflow_path)
-            return f"Task scheduled: {task_name}"
+            from praisonaiagents.tools.schedule_tools import schedule_add as _schedule_add
+            return _schedule_add(task_name, cron, workflow_path)
         except ImportError:
-            return "Error: Scheduler not available"
+            return "Error: Schedule tools not available"
         except Exception as e:
             return f"Error: {e}"
 
     @register_tool("praisonai.schedule.remove")
     def schedule_remove(task_name: str) -> str:
         """Remove a scheduled task."""
         try:
-            from praisonai.scheduler import AgentScheduler
-            scheduler = AgentScheduler()
-            scheduler.remove_task(task_name)
-            return f"Task removed: {task_name}"
+            from praisonaiagents.tools.schedule_tools import schedule_remove as _schedule_remove
+            return _schedule_remove(task_name)
         except ImportError:
-            return "Error: Scheduler not available"
+            return "Error: Schedule tools not available"
         except Exception as e:
             return f"Error: {e}"
 

src/praisonai/praisonai/tool_resolver.py

@@ -28,7 +28,7 @@
 import inspect
 import threading
 from pathlib import Path
-from typing import Any, Callable, Dict, List, Optional
+from typing import Any, Callable, Dict, List, Mapping, Optional
 from types import MappingProxyType
 
 logger = logging.getLogger(__name__)
@@ -53,12 +53,12 @@ def __init__(self, tools_py_path: Optional[str] = None):
             tools_py_path: Optional path to tools.py. If None, uses ./tools.py
         """
         self._tools_py_path = tools_py_path or "tools.py"
-        self._local_tools_cache: Dict[str, Callable] = {}
+        self._local_tools_cache: Mapping[str, Callable] = MappingProxyType({})
         self._local_tools_loaded: bool = False
         self._praisonai_tools_available: Optional[bool] = None
         self._local_tools_lock = threading.Lock()
 
-    def _load_local_tools(self) -> Dict[str, Callable]:
+    def _load_local_tools(self) -> Mapping[str, Callable]:
         """Load tools from local tools.py file.
         
         Security: Requires PRAISONAI_ALLOW_LOCAL_TOOLS=true to prevent