-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
security: cap litellm<=1.82.6 (supply chain incident) #1151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -14,7 +14,7 @@ dependencies = [ | |
| "pyparsing>=3.0.0", | ||
| "praisonaiagents>=1.5.83", | ||
| "python-dotenv>=0.19.0", | ||
| "litellm>=1.81.0", | ||
| "litellm>=1.81.0,<=1.82.6", | ||
| "PyYAML>=6.0", | ||
|
Comment on lines
15
to
18
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 1. Agents min version too low praisonaiagents was bumped to 1.5.84 (which contains the new litellm cap), but praisonai still allows older agent versions (and praisonai[claw] allows praisonaiagents[all]>=1.5.40), so dependency resolution can legitimately use an older agents release that doesn’t include the capped litellm spec for its extras. This weakens the supply-chain mitigation because installs can remain on an older agents version while still pulling litellm via agents extras. Agent Prompt
|
||
| "mcp>=1.20.0", | ||
| "typer>=0.9.0", | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change correctly caps the
litellmversion. However, the correspondinguv.lockfile for thepraisonaipackage seems to be missing from this pull request. Sincesrc/praisonai-agents/uv.lockwas updated, the lock file forpraisonaishould also be updated to reflect this dependency change and ensure that environments built using the lock file get the security fix. Please runuv lockin thesrc/praisonaidirectory and commit the updated lock file.