The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

src/praisonai-agents/mcp-sse-direct-server.py (3)

2-3: Remove unused imports to keep the module lean

typing.Any, httpx, and inspect are all imported but never used. Eliminating them avoids unnecessary byte-code generation and quiets Ruff F401 warnings.

-from typing import Any
-import httpx
-...
-import inspect

Also applies to: 14-14

🧰 Tools

🪛 Ruff (0.8.2)

2-2: typing.Any imported but unused

Remove unused import: typing.Any

(F401)

---

3-3: httpx imported but unused

Remove unused import: httpx

(F401)

---

79-80: Avoid accessing the private attribute mcp._mcp_server

Underscore-prefixed attributes are considered implementation details and may vanish without notice.
Expose the server via a public property or helper in the FastMCP library, or contribute such an accessor upstream.

---

88-90: Derive the tool list dynamically instead of hard-coding

Hard-coding tool names risks the list drifting from the actual exported tools.

-# Hardcode the tool names since we know what they are
-tool_names = ["get_greeting", "get_weather"]
+tool_names = [t.__name__ for t in mcp.tools]  # type: ignore[attr-defined]

This guarantees the CLI always prints the real set of registered tools.

src/praisonai-agents/praisonaiagents/mcp/mcp.py (2)

169-177: SSE endpoint detection could be too permissive

re.match(r'^https?://', …) treats any HTTP URL as an SSE endpoint.
Accidentally passing a non-SSE REST URL will silently route through the SSE client and fail later. Consider:

if isinstance(command_or_string, str) and command_or_string.endswith("/sse"):
    ...

or a stricter regex like r'^https?://.*?/sse$'.

---

340-347: Update the docstring to reflect the actual return type

to_openai_tool now returns list for both stdio and SSE paths, yet the docstring still mentions dict or list. Harmonising the return contract avoids confusion for downstream users.

-        """Convert the MCP tool to an OpenAI-compatible tool definition.
+        """Convert the MCP tools to OpenAI-compatible definitions.

...
-            dict or list: OpenAI-compatible tool definition(s)
+            list: List of OpenAI-compatible tool definitions

src/praisonai-agents/praisonaiagents/mcp/mcp_sse.py (1)

11-12: Prune unused imports to silence Ruff F401

json, List, Callable, and Iterable are imported but not referenced.

-import json
-from typing import List, Dict, Any, Optional, Callable, Iterable
+from typing import Dict, Any, Optional

🧰 Tools

🪛 Ruff (0.8.2)

11-11: json imported but unused

Remove unused import: json

(F401)

---

12-12: typing.List imported but unused

Remove unused import

(F401)

---

12-12: typing.Callable imported but unused

Remove unused import

(F401)

---

12-12: typing.Iterable imported but unused

Remove unused import

(F401)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

src/praisonai-agents/mcp-sse-direct-agent.py (3)

70-84: 🛠️ Refactor suggestion

Support positional arguments in __call__.

Currently, the method only accepts keyword arguments. To improve usability, support positional arguments by mapping them to parameter names based on the signature.

-    def __call__(self, **kwargs):
+    def __call__(self, *args, **kwargs):
         """Synchronous wrapper for the async call."""
         logger.debug(f"Tool {self.name} called with args: {kwargs}")
         
+        # Map positional args to the schema-defined names
+        if args:
+            positional_map = dict(zip(self.__signature__.parameters, args))
+            kwargs = {**positional_map, **kwargs}
+
         # Use the global event loop
         loop = get_event_loop()

---

114-122: ⚠️ Potential issue

Add a proper cleanup mechanism to prevent resource leaks.

The client creates asynchronous context managers but never calls their __aexit__ methods, which can lead to resource leaks.

 class SSEMCPClient:
     """A client for connecting to an MCP server over SSE."""
     
     def __init__(self, server_url: str):
         self.server_url = server_url
         self.session = None
         self.tools = []
         self._initialize()
+        
+    def __del__(self):
+        try:
+            self.close()
+        except Exception:
+            pass
+        
+    def close(self):
+        """Close the connection and clean up resources."""
+        loop = get_event_loop()
+        future = asyncio.run_coroutine_threadsafe(self._async_close(), loop)
+        future.result(timeout=10)
+        
+    async def _async_close(self):
+        """Asynchronously close the connection and clean up resources."""
+        if self.session:
+            await self._session_context.__aexit__(None, None, None)
+        if hasattr(self, "_streams_context"):
+            await self._streams_context.__aexit__(None, None, None)

---

123-139: ⚠️ Potential issue

Guard against runtime errors when creating multiple clients.

Starting a new thread per client with a shared event loop can cause RuntimeError: This event loop is already running when multiple clients are created.

     def _initialize(self):
         """Initialize the connection and tools."""
         # Use the global event loop
         loop = get_event_loop()
         
         # Start a background thread to run the event loop
         def run_event_loop():
             asyncio.set_event_loop(loop)
             loop.run_forever()
         
         import threading
-        self.loop_thread = threading.Thread(target=run_event_loop, daemon=True)
-        self.loop_thread.start()
+        # Only start the thread if the loop is not already running
+        if not loop.is_running():
+            self.loop_thread = threading.Thread(target=run_event_loop, daemon=True)
+            self.loop_thread.start()

Additionally, import threading at the module level rather than inside this method.

src/praisonai-agents/praisonaiagents/mcp/mcp_sse.py (3)

58-73: 🛠️ Refactor suggestion

Support positional arguments in __call__.

Currently, the method only accepts keyword arguments. To improve usability, support positional arguments by mapping them to parameter names based on the signature.

-    def __call__(self, **kwargs):
+    def __call__(self, *args, **kwargs):
         """Synchronous wrapper for the async call."""
         logger.debug(f"Tool {self.name} called with args: {kwargs}")
         
+        # Map positional args to the schema-defined names
+        if args:
+            positional_map = dict(zip(self.__signature__.parameters, args))
+            kwargs = {**positional_map, **kwargs}
+
         # Use the global event loop
         loop = get_event_loop()

---

127-143: ⚠️ Potential issue

Guard against runtime errors when creating multiple clients.

Starting a new thread per client with a shared event loop can cause RuntimeError: This event loop is already running when multiple clients are created.

     def _initialize(self):
         """Initialize the connection and tools."""
         # Use the global event loop
         loop = get_event_loop()
         
         # Start a background thread to run the event loop
         def run_event_loop():
             asyncio.set_event_loop(loop)
             loop.run_forever()
         
-        self.loop_thread = threading.Thread(target=run_event_loop, daemon=True)
-        self.loop_thread.start()
+        # Only start the thread if the loop is not already running
+        if not loop.is_running():
+            self.loop_thread = threading.Thread(target=run_event_loop, daemon=True)
+            self.loop_thread.start()

---

144-177: ⚠️ Potential issue

Missing clean-up of async contexts leaks network resources.

_streams_context.__aenter__() and _session_context.__aenter__() are called, but their corresponding __aexit__() are never invoked. Provide an explicit close() (and call it from __del__) to shut down the SSE connection gracefully.

+    async def _async_close(self):
+        """Asynchronously close the connection and clean up resources."""
+        if self.session:
+            await self._session_context.__aexit__(None, None, None)
+        if hasattr(self, "_streams_context"):
+            await self._streams_context.__aexit__(None, None, None)
+
+    def close(self):
+        """Close the connection and clean up resources."""
+        loop = get_event_loop()
+        future = asyncio.run_coroutine_threadsafe(self._async_close(), loop)
+        try:
+            future.result(timeout=10)
+        except Exception as e:
+            logger.error(f"Error closing SSE connection: {e}")
+
+    def __del__(self):
+        """Clean up resources when the object is garbage collected."""
+        try:
+            self.close()
+        except Exception:
+            pass

Neglecting to close can leave sockets open and stall interpreter shutdown.

src/praisonai-agents/mcp-sse-direct-agent.py (2)

1-20: Remove unused imports.

The following imports are not used in the file:

 import os
 import logging
 import asyncio
-import time
-import sys
 import inspect
 import json
-from typing import List, Dict, Any, Optional, Callable
-from contextlib import AsyncExitStack
+from typing import Dict, Any, Optional

🧰 Tools

🪛 Ruff (0.8.2)

4-4: time imported but unused

Remove unused import: time

(F401)

---

5-5: sys imported but unused

Remove unused import: sys

(F401)

---

8-8: typing.List imported but unused

Remove unused import

(F401)

---

8-8: typing.Callable imported but unused

Remove unused import

(F401)

---

9-9: contextlib.AsyncExitStack imported but unused

Remove unused import: contextlib.AsyncExitStack

(F401)

---

215-219: Import traceback at the module level instead of inside the exception handler.

+import traceback
+
 def main():
@@ ... @@
     except Exception as e:
         logger.error(f"Error: {e}")
-        import traceback
         traceback.print_exc()

src/praisonai-agents/praisonaiagents/mcp/mcp_sse.py (1)

1-17: Remove unused imports.

Several imported modules are not used in the code.

 import asyncio
 import logging
 import threading
 import inspect
-import json
-from typing import List, Dict, Any, Optional, Callable, Iterable
+from typing import Dict, Any, Optional

🧰 Tools

🪛 Ruff (0.8.2)

11-11: json imported but unused

Remove unused import: json

(F401)

---

12-12: typing.List imported but unused

Remove unused import

(F401)

---

12-12: typing.Callable imported but unused

Remove unused import

(F401)

---

12-12: typing.Iterable imported but unused

Remove unused import

(F401)

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro