-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Allow to configure reflection prompt #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
70043cb
Allow to configure reflection prompt
LeoVS09 c19216e
add agent constructor params description
LeoVS09 4b913a7
Merge remote-tracking branch 'leo-origin/feature/add-reflection-promp…
MervinPraison 750fb10
feat: add self-reflection support with configurable prompt to achat m…
claude[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The description of the default behavior for
reflect_llmcould be more precise.The current docstring states: "If None, uses the main llm parameter." However, the actual initialization logic is
self.reflect_llm = reflect_llm or os.getenv('OPENAI_MODEL_NAME', 'gpt-4o').This means if
reflect_llmisNone, it defaults to theOPENAI_MODEL_NAMEenvironment variable or 'gpt-4o', which is the same fallback as the mainllmif the mainllmitself wasNoneand not a custom instance. It doesn't directly use theself.llmvalue ifself.llmwas, for example, set to a different model string like "claude-2".Consider rephrasing to accurately reflect this fallback mechanism, similar to how the
llmparameter's default is described.