Skip to content

Add GitHub Container Registry login step and update Claude Code actio…#649

Merged
MervinPraison merged 1 commit intomainfrom
develop
Jun 15, 2025
Merged

Add GitHub Container Registry login step and update Claude Code actio…#649
MervinPraison merged 1 commit intomainfrom
develop

Conversation

@MervinPraison
Copy link
Copy Markdown
Owner

@MervinPraison MervinPraison commented Jun 15, 2025

User description

…n reference


PR Type

Enhancement


Description

• Add GitHub Container Registry authentication step
• Update Claude Code action to use containerized version
• Add packages read permission for registry access


Changes walkthrough 📝

Relevant files
Configuration changes
claude.yml
Add registry login and containerized action                           

.github/workflows/claude.yml

• Added packages read permission to job permissions
• Added GitHub
Container Registry login step using docker/login-action
• Updated
Claude Code action reference from local to containerized version

Configured registry authentication with GitHub actor and token

+9/-1     

Need help?
  • Type /help how to ... in the comments thread for any questions about Qodo Merge usage.
  • Check out the documentation for more information.
  • Summary by CodeRabbit

    • Chores
      • Updated workflow to use a container image from GitHub Container Registry.
      • Expanded job permissions to allow read access to GitHub Packages.
      • Added a step to log in to the GitHub Container Registry during workflow execution.

    @gemini-code-assist
    Copy link
    Copy Markdown
    Contributor

    Note

    Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

    @MervinPraison MervinPraison merged commit c8194cc into main Jun 15, 2025
    5 of 13 checks passed
    @coderabbitai
    Copy link
    Copy Markdown
    Contributor

    coderabbitai bot commented Jun 15, 2025

    Caution

    Review failed

    The pull request is closed.

    Walkthrough

    The GitHub Actions workflow for Claude Code was updated to grant read access to GitHub Packages, add a step for authenticating with the GitHub Container Registry, and switch the action execution from a local path to a container image hosted on ghcr.io. No changes were made to exported or public entities.

    Changes

    File(s) Change Summary
    .github/workflows/claude.yml Expanded job permissions, added GitHub Container Registry login step, and switched action usage to a ghcr.io container image.

    Sequence Diagram(s)

    sequenceDiagram
        participant GitHub Actions Runner
        participant GitHub Container Registry (ghcr.io)
        participant Claude Code Container
    
        GitHub Actions Runner->>GitHub Container Registry (ghcr.io): Authenticate with docker/login-action
        GitHub Actions Runner->>Claude Code Container: Run action from ghcr.io image
        Claude Code Container-->>GitHub Actions Runner: Execute Claude Code workflow steps
    
    Loading

    Possibly related PRs

    • Develop #646: Introduces the Docker container image for the Claude Code Action, which is now used in the updated workflow.
    • Add Claude Code GitHub Workflow #486: Implements the initial Claude Code GitHub Actions workflow, which the current PR modifies and extends.

    Suggested labels

    Review effort 4/5

    Poem

    A workflow hops with Docker cheer,
    To ghcr.io it now draws near.
    With secrets tucked and tokens tight,
    Claude Code runs in a container’s light.
    🐇 Containers spin, the code is clear—
    CI magic, rabbits engineer!


    📜 Recent review details

    Configuration used: CodeRabbit UI
    Review profile: CHILL
    Plan: Pro

    📥 Commits

    Reviewing files that changed from the base of the PR and between 34b7b57 and 362f2e5.

    📒 Files selected for processing (1)
    • .github/workflows/claude.yml (1 hunks)

    Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

    ❤️ Share
    🪧 Tips

    Chat

    There are 3 ways to chat with CodeRabbit:

    • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
      • I pushed a fix in commit <commit_id>, please review it.
      • Explain this complex logic.
      • Open a follow-up GitHub issue for this discussion.
    • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
      • @coderabbitai explain this code block.
      • @coderabbitai modularize this function.
    • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
      • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
      • @coderabbitai read src/utils.ts and explain its main purpose.
      • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
      • @coderabbitai help me debug CodeRabbit configuration file.

    Support

    Need help? Create a ticket on our support page for assistance with any issues or questions.

    Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

    CodeRabbit Commands (Invoked using PR comments)

    • @coderabbitai pause to pause the reviews on a PR.
    • @coderabbitai resume to resume the paused reviews.
    • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
    • @coderabbitai full review to do a full review from scratch and review all the files again.
    • @coderabbitai summary to regenerate the summary of the PR.
    • @coderabbitai generate docstrings to generate docstrings for this PR.
    • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
    • @coderabbitai resolve resolve all the CodeRabbit review comments.
    • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
    • @coderabbitai help to get help.

    Other keywords and placeholders

    • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
    • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
    • Add @coderabbitai anywhere in the PR title to generate the title automatically.

    CodeRabbit Configuration File (.coderabbit.yaml)

    • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
    • Please see the configuration documentation for more information.
    • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

    Documentation and Community

    • Visit our Documentation for detailed information on how to use CodeRabbit.
    • Join our Discord Community to get help, request features, and share feedback.
    • Follow us on X/Twitter for updates and announcements.

    @qodo-code-review
    Copy link
    Copy Markdown

    PR Reviewer Guide 🔍

    Here are some key observations to aid the review process:

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 Security concerns

    Token exposure:
    The same GH_TOKEN secret is used for both GitHub Container Registry authentication and the Claude Code action. This increases the attack surface and potential for token misuse. Consider using the built-in GITHUB_TOKEN for registry access if it has sufficient permissions, or use separate tokens with minimal required scopes for each purpose.

    ⚡ Recommended focus areas for review

    Missing Uses

    The Claude Code action step is missing the 'uses' keyword, which will cause the workflow to fail. The action reference should be prefixed with 'uses:'.

    uses: ghcr.io/mervinpraison/praisonai-claudecode:latest
    with:
    Token Security

    Using GH_TOKEN for both registry authentication and the Claude action may expose the token unnecessarily. Consider using GITHUB_TOKEN for registry access if sufficient permissions are available.

    password: ${{ secrets.GH_TOKEN }}
    

    @qodo-code-review
    Copy link
    Copy Markdown

    PR Code Suggestions ✨

    Explore these optional code suggestions:

    CategorySuggestion                                                                                                                                    Impact
    General
    Use built-in GitHub token

    Using a custom secret for authentication instead of the built-in GITHUB_TOKEN
    may cause permission issues. The GITHUB_TOKEN automatically has appropriate
    permissions for the workflow context and is the recommended approach for GitHub
    Container Registry authentication.

    .github/workflows/claude.yml [33-38]

     - name: Login to GitHub Container Registry
       uses: docker/login-action@v3
       with:
         registry: ghcr.io
         username: ${{ github.actor }}
    -    password: ${{ secrets.GH_TOKEN }}
    +    password: ${{ secrets.GITHUB_TOKEN }}
    • Apply / Chat
    Suggestion importance[1-10]: 9

    __

    Why: The suggestion correctly advises replacing the custom secret secrets.GH_TOKEN with the built-in secrets.GITHUB_TOKEN. This is a crucial security and maintainability best practice for authenticating with the GitHub Container Registry within a workflow, as the built-in token has automatically scoped permissions.

    High
    • More

    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

    Projects

    None yet

    Development

    Successfully merging this pull request may close these issues.

    1 participant