-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: handle MCP tools returning lists in agent.py #768
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| #!/usr/bin/env python3 | ||
| """Test script to verify MCP schema fix""" | ||
|
|
||
| import os | ||
| import sys | ||
|
|
||
| # Add the src directory to Python path | ||
| sys.path.insert(0, os.path.join(os.path.dirname(__file__), 'src', 'praisonai-agents')) | ||
|
|
||
| from dotenv import load_dotenv | ||
| from praisonaiagents import Agent, MCP | ||
|
|
||
| # Load .env before importing anything else | ||
| load_dotenv() | ||
|
|
||
| # Define allowed directories for filesystem access | ||
| allowed_dirs = [ | ||
| "/Users/praison/praisonai-package/src/praisonai-agents", | ||
| ] | ||
|
|
||
| # Test with minimal example | ||
| print("Testing MCP filesystem agent...") | ||
|
|
||
| try: | ||
| # Use the correct pattern from filesystem MCP documentation | ||
| filesystem_agent = Agent( | ||
| instructions="""You are a helpful assistant that can interact with the filesystem. | ||
| Use the available tools when relevant to manage files and directories.""", | ||
| llm="gpt-4o-mini", | ||
| tools=MCP( | ||
| command="npx", | ||
| args=["-y", "@modelcontextprotocol/server-filesystem"] + allowed_dirs | ||
| ) | ||
| ) | ||
|
|
||
| print("✓ Agent created successfully") | ||
| print("✓ MCP tools loaded without schema errors") | ||
|
|
||
| # Try to start the agent (this will validate the tool schemas) | ||
| result = filesystem_agent.start("List files in /Users/praison/praisonai-package/src/praisonai-agents directory using MCP list_files") | ||
| print("✓ Agent executed successfully") | ||
| print(f"Result: {result}") | ||
|
|
||
| except Exception as e: | ||
| print(f"✗ Error: {e}") | ||
| import traceback | ||
| traceback.print_exc() | ||
| sys.exit(1) | ||
|
|
||
| print("\nTest passed! The MCP schema fix is working correctly.") | ||
|
Comment on lines
+24
to
+50
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifying
sys.pathis generally discouraged as it can create fragile tests and obscure import dependencies. Consider structuring your project as an installable package and usingpip install -e .for development.[^1]