Skip to content

Commit 06017db

Browse files
authored
Fix setup python 3.8 (#4716)
1 parent a1b2543 commit 06017db

2 files changed

Lines changed: 7 additions & 3 deletions

File tree

.github/workflows/pip-build.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ jobs:
192192
- name: Checkout
193193
uses: actions/checkout@v4
194194
with:
195-
submodules: true
195+
submodules: recursive
196196
ref: ${{needs.setup.outputs.version_tag}}
197197

198198
- name: Checkout Vcpkg ${{env.VCPKG-VERSION}}
@@ -334,7 +334,7 @@ jobs:
334334
- name: Checkout
335335
uses: actions/checkout@v4
336336
with:
337-
submodules: true
337+
submodules: recursive
338338
ref: ${{needs.setup.outputs.version_tag}}
339339

340340
- name: Python setup

scripts/mrbind-pybind11/install_all_python_versions_ubuntu_reqs.sh

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,11 @@ echo "Python versions: $PY_VERSIONS"
1212

1313
# Install the dependencies.
1414
for ver in $PY_VERSIONS; do
15-
curl -sS https://bootstrap.pypa.io/get-pip.py | python$ver
15+
if [[ $ver == 3.8 ]]; then
16+
curl -sS https://bootstrap.pypa.io/pip/3.8/get-pip.py | python$ver
17+
else
18+
curl -sS https://bootstrap.pypa.io/get-pip.py | python$ver
19+
fi
1620
python$ver -m pip install --upgrade -r ./requirements/python.txt
1721
python$ver -m pip install pytest
1822
done

0 commit comments

Comments
 (0)