[SANDBOX/DO-NOT-MERGE] verify prepare-images disable-build-* skipping for #6029#6030
Closed
[SANDBOX/DO-NOT-MERGE] verify prepare-images disable-build-* skipping for #6029#6030
Conversation
Plumb the disable-build-<platform> labels (already resolved into
build_enable_<platform> outputs in config.yml) through to the
prepare-images workflow so it skips image builds the PR has opted out of.
Mapping (label → skipped):
- disable-build-ubuntu-x64 → ubuntu22/x64, ubuntu24/x64
- disable-build-ubuntu-arm64 → ubuntu22/arm64, ubuntu24/arm64
- disable-build-emscripten → emscripten/arm64
- disable-build-linux-vcpkg → rockylinux8-vcpkg/{x64,arm64}
- disable-build-windows → vs2019, vs2022 vcpkg cache builds
Avoids burning runner time producing images no downstream build job
will consume.
First attempt referenced `matrix.*` from a job-level `if:` for the linux-image-build-upload job, which fails workflow validation: Unrecognized named-value: 'matrix'. The `matrix` context isn't available in job-level `if:` for reusable workflow inputs. Compute the include list in a tiny upstream job and feed it via `fromJSON()` instead.
…-* labels Throwaway commit on a sandbox branch (NOT for merge) to trigger need_linux_image_rebuild + need_linux_vcpkg_rebuild + need_windows_vcpkg_rebuild so PR #6029's per-cell / per-job label skipping in prepare-images.yml can actually be observed in CI.
Dynamic-include cells get auto-named from every key in the entry, so the previous shape produced linux-image-build-upload (ubuntu22, arm64, -arm64, ubuntu-24.04-arm) duplicating arm64 and leaking runner/image-suffix details. Drop image-suffix and os from the matrix entries and derive both from matrix.arch inline (runs-on + image env). Cell name is now just "(<distro>, <arch>)", matching the static-matrix baseline.
Contributor
Author
|
Sandbox PR — closing. Verification confirmed PR #6029 works end-to-end. Two image-build failures were unrelated transient Launchpad PPA timeouts inside the Dockerfile apt chain. Branch HEAD preserved as tag wip/sandbox-test-disable-labels-pr-6030. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sandbox / DRAFT — do not merge
Throwaway PR to exercise the per-cell / per-job
disable-build-*label skipping introduced in #6029. Branched offci-prepare-images-respect-disable-labels(so PR #6029's logic is in effect) plus a tiny touch to two trigger paths so all threeneed_*_rebuildflags fire:docker/ubuntu22Dockerfile(comment line) →need_linux_image_rebuild=truethirdparty/vcpkg/triplets/x64-linux-meshlib.cmake(comment line) →need_linux_vcpkg_rebuild=trueandneed_windows_vcpkg_rebuild=trueLabels applied
disable-build-ubuntu-x64— should dropubuntu22/x64+ubuntu24/x64cells fromlinux-image-build-uploaddisable-build-windows— should skipwindows-vcpkg-build-upload(despiteneed_windows_vcpkg_rebuild=true)disable-build-linux-vcpkg— should skiplinux-vcpkg-build-upload(despiteneed_linux_vcpkg_rebuild=true)disable-build-macos— keeps macos out of CI burnExpected results
prepare-imagejobs:compute-linux-image-matrixlinux-image-build-uploadubuntu22-arm64,ubuntu24-arm64,emscripten-arm64; no*/x64cellslinux-vcpkg-build-uploadwindows-vcpkg-build-uploadDownstream
*-build-testjobs are not the focus here — the user can cancel them onceprepare-imagereports complete to limit CI burn.After verification
Close without merging.