Ability to define custom projection. #166
Open
Thomas Crocker (thomascrocker) wants to merge 1 commit into
Open
Ability to define custom projection. #166Thomas Crocker (thomascrocker) wants to merge 1 commit into
Thomas Crocker (thomascrocker) wants to merge 1 commit into
Conversation
Nick Savage (nhsavage)
assigned
Nick Savage (nhsavage) and unassigned
Nick Savage (nhsavage)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the ability to explicitly set the projection used to produce the plot. The prior behaviour simply used the projection of the supplied data. It addresses #164
If the user specifies a projection that is different to that of the supplied data, the data is transformed onto the new projection.
Also if the data does not have a co-ordinate system (e.g. most of the CMIP5 data under /project/champ) PlateCarree is assumed.
Lastly I removed the try clauses around getting the x and y coords, since if a coord not found error is ignored here it will almost certainly cause problems further on but be harder to debug.