#981 Add missing ocean and seaIce grid labels#990
#981 Add missing ocean and seaIce grid labels#990Jared Drayton (mo-jareddrayton) wants to merge 3 commits into
Conversation
Matthew Mizielinski (matthew-mizielinski)
left a comment
There was a problem hiding this comment.
One small tweak to do, but otherwise looks good
Matthew Mizielinski (matthew-mizielinski)
left a comment
There was a problem hiding this comment.
Have found a few very minor mis-mappings of variables to grids in the seaice -- all minor modifications
| siforceintstrx_tavg-u-hxy-si = ocean tripolar-native | ||
| siforceintstry_tavg-u-hxy-si = ocean tripolar-native | ||
| siforcetiltx_tavg-u-hxy-si = ocean tripolar-native | ||
| siforcetilty_tavg-u-hxy-si = ocean tripolar-native |
There was a problem hiding this comment.
I think these should be tripolar-ugrid (x) or tripolar-vgrid (y) depending on the last letter of the variable name
there will be a variable called siforcecorioly_tavg-u-hxy-si appearing shortly and this should be tripolar-ugrid
There was a problem hiding this comment.
Ah, I was doing this based on the dimension names. I guess that isn't reliable for x/y components then?
float siforceintstrx(time_counter, y_grid_T, x_grid_T) ;
siforceintstrx:standard_name = "internal_stress_in_sea_ice_x" ;
siforceintstrx:long_name = "(Internal stress term in force balance (x-component)) * (sea ice area fraction)" ;
siforceintstrx:units = "N/m2" ;
siforceintstrx:online_operation = "average" ;
siforceintstrx:interval_operation = "1 month" ;
siforceintstrx:interval_write = "1 month" ;
siforceintstrx:cell_methods = "time: mean" ;
siforceintstrx:cell_measures = "area: area_grid_T" ;
siforceintstrx:_FillValue = 1.e+20f ;
siforceintstrx:missing_value = 1.e+20f ;
siforceintstrx:coordinates = "time_centered nav_lat_grid_T nav_lon_grid_T" ;
There was a problem hiding this comment.
There was a mistake in the si3 configuration that wasn't discovered until late
| siu_tavg-u-hxy-si = ocean tripolar-native | ||
| siv_tavg-u-hxy-si = ocean tripolar-native |
There was a problem hiding this comment.
These should be tripolar-ugrid and tripolar-vgrid
| sistrxdtop_tavg-u-hxy-si = ocean tripolar-native | ||
| sistrxubot_tavg-u-hxy-si = ocean tripolar-native | ||
| sistrydtop_tavg-u-hxy-si = ocean tripolar-native | ||
| sistryubot_tavg-u-hxy-si = ocean tripolar-native |
There was a problem hiding this comment.
I've just found these four in the mappings with the coordinate replacement processor
sistrx(dtop|ubot) -> tripolar-ugrid
sistry(dtop|ubot) -> tripolar-vgrid
858dd9c to
e829c34
Compare
Matthew Mizielinski (matthew-mizielinski)
left a comment
There was a problem hiding this comment.
One query otherwise good
|
|
||
| [ocnBgchem] | ||
| fgdms_tavg-u-hxy-sea = atmos latlon-native | ||
| fgdms_tavg-u-hxy-sea = ocean latlon-native |
There was a problem hiding this comment.
could you double check this one -- I think it might need to be atmos as before, because it is output by the UM
Closes #981.
A chunk of seaIce and ocean grid labels were missing, partially due to the base defaults still getting picked up. This PR should add labels for all mappings that are present for ukcm2 at this point in the repository.
Some of the ancils I needed to specify manually but not sure if these are the right mappings Matthew Mizielinski (@matthew-mizielinski) ?