add check for commands from string#102
Merged
James Bruten (james-bruten-mo) merged 4 commits intoAug 19, 2025
Merged
Conversation
James Bruten (james-bruten-mo)
requested review from
Cameron Bateman (cameronbateman-mo) and
mo-nikosbaltas
and removed request for
a team
July 16, 2025 16:30
Cameron Bateman (cameronbateman-mo)
approved these changes
Jul 17, 2025
Cameron Bateman (cameronbateman-mo)
left a comment
Cameron Bateman (cameronbateman-mo)
left a comment
Contributor
There was a problem hiding this comment.
Sensible solution.
Cameron Bateman (cameronbateman-mo)
approved these changes
Jul 21, 2025
mo-nikosbaltas
approved these changes
Jul 29, 2025
mo-nikosbaltas
left a comment
mo-nikosbaltas
left a comment
There was a problem hiding this comment.
Sensible changes that fulfil requirements.
James Bruten (james-bruten-mo)
merged commit Aug 19, 2025
1c9fec5
into
MetOffice:main
5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
If an upgrade macro gets run multiple times as part of development, the automatically added "Commands From: ..." comment can get added a number of times. This adds a check that the comment doesn't already exist before writing it. I've checked that this works on an existing Apps branch with a macro.
Checklist