Validate rose meta#105
Merged
Jenny Hickson (jennyhickson) merged 16 commits intoAug 29, 2025
Merged
Conversation
James Bruten (james-bruten-mo)
requested review from
Cameron Bateman (cameronbateman-mo) and
R Sharp (r-sharp)
and removed request for
a team
August 19, 2025 13:30
James Bruten (james-bruten-mo)
requested review from
Jenny Hickson (jennyhickson)
and removed request for
R Sharp (r-sharp)
August 21, 2025 08:23
Cameron Bateman (cameronbateman-mo)
approved these changes
Aug 27, 2025
Co-authored-by: Cameron Bateman <cameron.bateman@metoffice.gov.uk>
Collaborator
Author
|
Thanks Cameron, I've committed the bottom suggestion which is a good shout. I've not done the other ones. The reason for storing the state in the variable is it lets us run the test for all apps before raising an error, so we find all the issues immediately rather than fixing one and running again |
James Bruten (james-bruten-mo)
requested a review
from Cameron Bateman (cameronbateman-mo)
August 27, 2025 09:33
Cameron Bateman (cameronbateman-mo)
approved these changes
Aug 28, 2025
Cameron Bateman (cameronbateman-mo)
left a comment
Cameron Bateman (cameronbateman-mo)
left a comment
Contributor
There was a problem hiding this comment.
All looks good 👍👌
Jenny Hickson (jennyhickson)
left a comment
Jenny Hickson (jennyhickson)
left a comment
Collaborator
There was a problem hiding this comment.
Generally good - a few odds and sods :)
James Bruten (james-bruten-mo)
left a comment
James Bruten (james-bruten-mo)
left a comment
Collaborator
Author
There was a problem hiding this comment.
Thanks Jenny, changes made
James Bruten (james-bruten-mo)
requested a review
from Jenny Hickson (jennyhickson)
August 28, 2025 16:21
Yaswant Pradhan (yaswant)
left a comment
Yaswant Pradhan (yaswant)
left a comment
Collaborator
There was a problem hiding this comment.
Since this is a completely new addition, please consider type hints.
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Co-authored-by: Yaswant Pradhan <2984440+yaswant@users.noreply.github.com>
Collaborator
Author
|
Given I've adapted this from an existing script that was in the Apps repo (and it's pretty straightforward) I'll leave off adding the type hinting for now. |
…s_Scripts into validate_rose_meta
Jenny Hickson (jennyhickson)
approved these changes
Aug 29, 2025
Jenny Hickson (jennyhickson)
left a comment
Jenny Hickson (jennyhickson)
left a comment
Collaborator
There was a problem hiding this comment.
Thanks for sorting. Looks good to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary
Refactor validate_rose_meta.py and move it to SimSys_Scripts. The script will now automatically find metadata sections and apps to validate (ignoring a list of exceptions) rather than only testing based on a hardcoded list. This was done previously and meant that new metadata sections were regularly not tested.
Coordinated merge
This ticket needs to be committed before:
LFRic Apps #954
LFRic Core #4666
Checklist