temporary fix for kgo updates#110
Merged
Sam Clarke-Green (t00sa) merged 1 commit intoSep 9, 2025
Merged
Conversation
James Bruten (james-bruten-mo)
requested a review
from Sam Clarke-Green (t00sa)
September 9, 2025 14:46
James Bruten (james-bruten-mo)
requested a review
from a team
as a code owner
September 9, 2025 14:46
Sam Clarke-Green (t00sa)
approved these changes
Sep 9, 2025
Sam Clarke-Green (t00sa)
left a comment
Sam Clarke-Green (t00sa)
left a comment
Collaborator
There was a problem hiding this comment.
Looks sensible. Approved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This script needs to work for both lfric and UM kgo, so needs to able to work with variables.cylc files and variables.rc files. It works out the extension by looking for either the flow.cylc or suite.rc in the top level rose-stem directory.
Unfortunately the UM was updated to use a flow.cylc, but didn't rename all the files. So it needs .rc extension but has a flow.cylc and so this script has broken.
Fix temporarily by looking for family-common.rc instead of suite.rc. By vn14.0 it will use all .cylc extensions, so all this logic can be removed.
Checklist