Rename meshes for benefit of lfric2lfric#551
Draft
cjohnson-pi wants to merge 25 commits into
Draft
Conversation
29 tasks
|
Your CLA signature was found on the base branch, but you appear to have modified the CONTRIBUTORS.md file in this PR. Please do not edit the CONTRIBUTORS.md file. If you have already signed the CLA, revert changes to the file and your signature will be picked up. |
28 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Rename the mesh names (including prime_mesh_name, chain_mesh_tags, destination_mesh_name and source_mesh_name).
Sci/Tech Reviewer:
Code Reviewer:
blocks #530
MetOffice/lfric_core#386
Code Quality Checklist
Testing
trac.log
Run by first applying to the associated
lfric_corebranch$UMDIR/SimSys_Scripts/lfric_macros/apply_macros.py vn3.1_t11 --core=. --apps='/home/users/christine.johnson/git/lfric_apps'Then applying to this
lfric_appsbranch$UMDIR/SimSys_Scripts/lfric_macros/apply_macros.py vn3.1_t16Test Suite Results - lfric_apps - test_rename_meshes/run8
Suite Information
Task Information
✅ succeeded tasks - 1198
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review