Change wind names in lfricinputs to match names used in lfric_atm#565
Merged
Harry Shepherd (harry-shepherd) merged 5 commits intoJul 16, 2026
Merged
Conversation
Steve Mullerworth (stevemullerworth)
marked this pull request as ready for review
June 26, 2026 14:58
Contributor
There was a problem hiding this comment.
I haven't looked at PRs that introduce changes to input files before; will these $DATADIR/pr565 paths be reverted to standard paths before merging the branch?
Collaborator
Author
There was a problem hiding this comment.
Yes. Following normal practice, once the change is ready for commit to main, the new files will be centrally installed in our local $DATADIR. They will be installed in additional to the old files so as not to break tests of older versions. These additional files would be needed by any partners who run the full test suite.
Wolfgang Hayek (tinyendian)
approved these changes
Jun 29, 2026
Wolfgang Hayek (tinyendian)
left a comment
Wolfgang Hayek (tinyendian)
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me; I don't think we currently run any of the affected tests at ESNZ, but we'll update input files should the need arise.
Lottie Turner (mo-lottieturner)
approved these changes
Jul 1, 2026
Harry Shepherd (harry-shepherd)
approved these changes
Jul 16, 2026
Harry Shepherd (harry-shepherd)
merged commit Jul 16, 2026
8c5dcbd
into
MetOffice:main
7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Lottie Turner (@mo-lottieturner)
Code Reviewer: Harry Shepherd (@harry-shepherd)
In lfric_atm, the cell-centred horizontal winds are named
u_in_w3andv_in_w3. The vertical wind isw_in_wthas it is on Wtheta. But lfricinputs still assumes older names:ew_wind,ns_windandupward_wind.This PR changes the names to match those now used in lfric_atm, as it will be lfric_atm data that the tools work on.
Some of the LFRic dumps used by lfric2um have been changed to include the new name, and are currently held here:
$DATADIR/pr565/standard_jobs/lfricinputs/inputs/v3.2/The
lfric2um_startdump_aquaplanet_N48L38_C48L38.ncandnwp-gal9_N320L70_C224L70.ncare copies of the output from the matching um2lfric run in the suite. Thelfric2um_startdump_um-lam_C48L70.ncis generated by usingncrenameto rename the three wind variables.Because two of the lfric2um input files were new dumps, the rose-ana tasks of the tasks that use these files do not pass. The tests were rerun with the jobs pointing at files generated from the original dumps by using
ncrename. This time the lfric2um rose-ana tests pass, demonstrating that the prior failures are due to the differences in the input dump. The alternate files are held in amodified_origdirectory next to the abovev3.2directory.$DATADIR/pr565/standard_jobs/lfricinputs/inputs/modified_orig/The files in one or other of the directories above will need to be moved to a central location such as $BIG_DATA prior to the final commit, and
rose-stem/site/common/lfricinputs/tasks_lfric2um.cylcwill need to be updated to point to the new locations.As expected, the
um2lfricandsciintelapirose-ana tests fail due to the change in names in the output files: A KGO update will be required.Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_apps - pr565_for_review/run1
Suite Information
Task Information
❌ failed tasks - 46
trac.log with ncrename-modified files
Result can be found here, as
trac.loggeneration will not work:https://cylchub/services/cylc-review/cycles/steve.mullerworth/?suite=pr565_for_review%2Frun2
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review