PP import transmute fix#566
Draft
Benjamin Went (MetBenjaminWent) wants to merge 2 commits into
Draft
Conversation
Contributor
Author
|
Joseph Abram (@J-J-Abram), so that you are aware! |
Contributor
Author
|
Passed to Matthew for when his changes make trunk, likely otherwise to be cosed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
There are some core changes coming which will mean that all source is pre-processed on import.
This means that our pre-prcoess step no longer is needed as is, but instead is needed to move the
f90file to anux90file, so that Transmute can run and produce af90file, but with the Transmute updates.Sci/Tech Reviewer:
Code Reviewer:
Code Quality Checklist
Testing
trac.log
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review